Spores don't prevent capture of `this` about spores HOT 8 CLOSED

Hi @dimbleby, thanks for passing by.

This PR #44 does show that the expected behaviour is indeed to throw errors for uncaptured variables. I just tried to model the akka logic very badly (don't pay attention to it) so that i can copy/paste your code from here to convince you that it works.

Despite the example I provide works, it looks like you may have found a corner case that our macros are not handling. In order to fix it, it would be useful if you can share that code or, even better, to submit a PR just like the one I did showing that your example fails.

As a side note, you got the concept correctly.

from spores.

Hi, thanks for the quick response.

I've put a complete (but small) example project here - in particular, see these lines.

from spores.

Great! I think it's a bug that should have a rather straightforward fix. Have you been able to reproduce it without the use of delayed?

from spores.

Sure, it makes no difference.

from spores.

Nice, I'll work on it and get back to you when I get it solved. Thanks for the error report!

from spores.

Hi @dimbleby, as I expected, this issue only occurs in 0.2.1, but it doesn't in the most up-to-date 0.2.3 version. I've just added three tests that replicate exactly your toy project, and they fail. When cloning your project and changing spores version to 0.2.3 AND publishing locally, the project compiles just fine.

We're due to cut a release very soon. If you find yourself in a hurry, publish locally via sbt. Hope to have solved your problem, I'll be waiting for your confirmation.

from spores.

Great, thanks. I'll look forward to trying again with the new release.

If you're satisfied that this is fixed, please feel free to close the issue without waiting for my confirmation - I can always open a new one if I still see problems!

from spores.

Great, thanks!

Let's do that. You can see that tests are passing #44.

from spores.