Giter VIP home page Giter VIP logo

Comments (6)

mjradwin avatar mjradwin commented on August 26, 2024

Thanks for the feedback. I'm still new to Golang and have been trying to follow best practices.

We'll look into the JSON APIs and try to get a release out

from hebcal-go.

mjradwin avatar mjradwin commented on August 26, 2024

Fixed in v0.9.17

from hebcal-go.

chabad360 avatar chabad360 commented on August 26, 2024

It would be preferable if the format is:

{
  "day": 19,
  "month": 3,
  "year": 5783
}

At least to retain backwards compatibility.

But otherwise this is great, thank you very much!

from hebcal-go.

mjradwin avatar mjradwin commented on August 26, 2024

The format implemented matches what is currently used on hebcal.com. We have a preference for string month names because in the world of Hebrew dates there can be ambiguity about whether month 1 is Nissan or Tishrei.

Sorry for the compatibility break. We have been releasing this library as 0.9.x because we expected some breaking changes like this.

from hebcal-go.

chabad360 avatar chabad360 commented on August 26, 2024

Fair enough. I'll have to see how I'm going to work around that, but this is a good start.

from hebcal-go.

mjradwin avatar mjradwin commented on August 26, 2024

Our apologies for the inconvenience.

We're hoping to avoid hassles like this in the future by stabilizing some key interfaces. hdate is now its package split out from this monorepo into its own repo/module. We've given it a v1.0.0 stable version number, and won't make any breaking changes without increasing the major version number.

Instead of importing github.com/hebcal/hebcal-go/hdate, you'll now want to import github.com/hebcal/hdate

from hebcal-go.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.