Giter VIP home page Giter VIP logo

Comments (5)

SISheogorath avatar SISheogorath commented on May 14, 2024 1

Some hints for implementation:

In order to fix the light mode for the toolbar, there will be the need of manipulating the classes of the toolbar element using this function:
https://github.com/codimd/server/blob/36c083277e6c74bb6eac495971522e6932cfc207/public/js/lib/editor/index.js#L414-L447

The color difference between the upload button and the rest comes from this class:

https://github.com/codimd/server/blob/36c083277e6c74bb6eac495971522e6932cfc207/public/css/index.css#L14-L17

Finally the toolbar itself can be found here: https://github.com/codimd/server/blob/master/public/js/lib/editor/toolbar.html

If any further help is needed, feel free to reach out :)

from hedgedoc.

ccoenen avatar ccoenen commented on May 14, 2024

at the same time, the upload button does not honor night mode:

grafik

from hedgedoc.

SISheogorath avatar SISheogorath commented on May 14, 2024

😅 Who didn't take care of that? I'll provide a PR to fix both :)

In order to leave it to someone who is new to the project and wants to take their first steps, I'll leave this to them.

from hedgedoc.

HerHde avatar HerHde commented on May 14, 2024

Oh, and the label changes to the last chosen file's name. Not sure whether this is intended, but I guess it's due to the <input type="file">.
And you get no response if the chosen file type is not supported.

from hedgedoc.

ccoenen avatar ccoenen commented on May 14, 2024

Most of this ticket has been fixed in #44, and I created #63 to address the upload button at a later time.

from hedgedoc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.