Giter VIP home page Giter VIP logo

Comments (2)

ccoenen avatar ccoenen commented on May 13, 2024 1

I think this would make a very nice first issue: The button leads to a URL that is essentially /s/<note-id>/edit which is then defined as a route here:

https://github.com/codimd/server/blob/f13a91c6988b55a0cd50fc530bdc13baa96bf3b4/lib/web/noteRouter.js#L18

and which will lead to this function that actually does the rediect.

https://github.com/codimd/server/blob/f13a91c6988b55a0cd50fc530bdc13baa96bf3b4/lib/response.js#L422-L437

So, essentially by changing this line, you could solve your own request:

https://github.com/codimd/server/blob/f13a91c6988b55a0cd50fc530bdc13baa96bf3b4/lib/response.js#L430

There's a similar thing in slides mode by the way, the two should be fixed at the same time:

https://github.com/codimd/server/blob/f13a91c6988b55a0cd50fc530bdc13baa96bf3b4/lib/response.js#L444

All that would be needed is to add ?both to the url!

from hedgedoc.

stragu avatar stragu commented on May 13, 2024 1

Thanks heaps for the explanations! I definitely needed some hand-holding :)

Hopefully this does it: #37

Cheers

from hedgedoc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.