Export ClientOptions from 'ws' about isomorphic-ws HOT 10 OPEN

Since you are installing ws anyway, you can use the following code:

import { ClientOptions } from 'ws'

from isomorphic-ws.

Isn't it necessary to add more lines like..

import type { ClientOptions } from 'ws'

export { ClientOptions }
export default WebSocket

from isomorphic-ws.

It seems like a problem with:

It should be

@paralin Which version of isomorphic-ws did you used?

from isomorphic-ws.

@heineiuo currently using 4.0.1 in https://github.com/aperturerobotics/starpc -

I tried importing as import { ClientOptions } from 'isomorphic-ws' since the same works with 'ws' - but of course, that's not exported currently.

from isomorphic-ws.

@paralin I didn't get errors with 4.0.1:

https://codesandbox.io/s/nervous-fire-9hnffn?file=/src/App.tsx

from isomorphic-ws.

@heineiuo

I guess it's expected now to use export = WebSocket instead of export default WebSocket ?

from isomorphic-ws.

@heineiuo

I guess it's expected now to use export = WebSocket instead of export default WebSocket ?

Yes. I'm going to revert the commit which did not published actually.

from isomorphic-ws.

Isn't it necessary to add more lines like..

import type { ClientOptions } from 'ws'

export { ClientOptions }
export default WebSocket

No, it's unnecessary because @types/ws did export = WebSocket;

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/ea4d4e50e11788ef0a8094d7de564ad2f01dfedd/types/ws/index.d.ts#L377

from isomorphic-ws.

@JoCat @heineiuo I guess there's some confusion here on what I'm asking...

If I try to do this, it doesn't work:

import { ClientOptions } from 'isomorphic-ws'

Is there something that I'm doing wrong here?

from isomorphic-ws.

@JoCat @heineiuo I guess there's some confusion here on what I'm asking...

If I try to do this, it doesn't work:

import { ClientOptions } from 'isomorphic-ws'

Is there something that I'm doing wrong here?

Could you provide a minimal project or a codesandbox link (just like I submitted above)?

from isomorphic-ws.