Cannot set property 'files' about hela HOT 9 CLOSED

Strange. It's not on L125, but okey. Can you give the full stack and use case example?

from hela.

Occurs when:

• There is no data in the request body.
• Specified filesKey = false
• Request multipart

from hela.

@isdenya thanks for the info. I'm working on next release locally.

from hela.

This same bug happens if you post an empty body with fieldsKey = false.
At line L115 (returns = cache.fields;) returns is set to undefined, so when you get to L125 (returns[filesKey] = cache.files;) you're assigning a field of an undefined object, and it breaks.

from hela.

@sedenardi good point.

from hela.

@tunnckoCore I think the main issue is that L87 this.request.body !== undefined fails because you're posting with an empty body. I usually use an empty body when implementing /Logout in my APIs, so I think this is a valid use case.

from hela.

Agreed. 👍

I'm trying to come to this as soon as possible, or at least to push my local things to new branch and to be able others to continue.

PRs are always welcome, i'm just too busy and i'm not using this package anywhere atm.

from hela.

@tunnckoCore Cool. I'll run my possible fix through a couple of different scenarios and make sure your tests don't break and submit a PR in the next few days.

from hela.

Yea, thanks. If you can easy fix it for current version it would be great. I'm open.

from hela.