Giter VIP home page Giter VIP logo

Comments (4)

romain-grecourt avatar romain-grecourt commented on June 26, 2024

Why do we need to explicitly configure the plugin version ?
It can (should?) just be derived from the application parent pom.

If we have a way to pass properties to the forked maven command, it can be used to override version.helidon.plugin.

Also, deriving the plugin version used by the CLI directly from the application pom would allow us to deliver bug fixes for the plugins without necessarily having to publish a new CLI version.

from helidon-build-tools.

batsatt avatar batsatt commented on June 26, 2024

I think helidon init should be able to select the plugin version, rather than have it bound to the Helidon version from which the parent pom comes.

The case I was thinking about is when we have more than one 2.x release (e.g. 2.0.0, 2.1.0), and a new CLI release (e.g. 2.1.0 if was tracking helidon releases). If you then use the 2.1.0 CLI and select an older version of helidon:

    helidon init --version 2.0.0

what version of the plugin should be configured in the app? I think the default behavior should be that you end up with 2.1.0 rather than 2.0.0. If the actual version used comes from our new metadata file, we can deliver plugin fixes that way.

And yes, we could temporarily change the version when under the CLI by passing the property, but that disappears when mvn is used directly.

from helidon-build-tools.

romain-grecourt avatar romain-grecourt commented on June 26, 2024

If we include the latest plugin version in the new metadata file, then that works.
I'm not sure I understand your last point ; if mvn is invoked directly the CLI is not involved right ?

from helidon-build-tools.

batsatt avatar batsatt commented on June 26, 2024

Right, and so any "update" of the plugin version via the property would not (automatically) be in effect. I don't think we want different plugin versions depending on how you do the build.

We should select the plugin version during init and expand the template such that this version is used.

For other commands that do builds, if we get metadata that says there is a newer plugin version, we could ask the user if we can update the app pom with the new version.

All of this suggests to me that we have to be able to control the plugin version in the app pom, not the parent.

from helidon-build-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.