Giter VIP home page Giter VIP logo

Comments (7)

philltran avatar philltran commented on June 15, 2024

Adding the country looks easy enough since there is a data.long_country field.

The issue of not showing the international province may be an upstream issue.

    {
      "address": "112kSXBK6iJReNq2iihxGE9gwGymPTcfYnJ9yn4ucGvYkCqYq1HW",
      "id": 4102,
      "lat": 52.536173153662375,
      "lng": 13.406815834090017,
      "location": "8c1f1d4899751ff",
      "long_city": "Berlin",
      "long_country": "Germany",
      "long_state": "Berlin",
      "long_street": "Schwedter Straße",
      "name": "Passive Golden Ape",
      "owner": "13LB84v8EpPPWbnscH8sd6RbfPjWU8YLoLWuqMKrwwqx6qxxhiT",
      "score": 0.25,
      "score_update_height": 357111,
      "short_city": "Berlin",
      "short_country": "DE",
      "short_state": "Berlin",
      "short_street": "Schwedter Str."
    },

from explorer.

abhay avatar abhay commented on June 15, 2024

Looks like the duplicate is due to the fact that the province is also called Berlin. @madninja any generalized advice here? Should the API provide a "formatted city" instead?

from explorer.

philltran avatar philltran commented on June 15, 2024

Ah. Sorry for my lack of world geography knowledge. lol

Thanks for looking in to that.

from explorer.

madninja avatar madninja commented on June 15, 2024

This is what the geocoder returns for various localities @abhay. I'd rather not have any API include "display" strings since that is extremely app specific?

from explorer.

abhay avatar abhay commented on June 15, 2024

Generally agree on not prescribing display but we already are with a locale assumption. Other option could be for us to geocode live in the app with the user's browser locale.

from explorer.

madninja avatar madninja commented on June 15, 2024

Generally agree on not prescribing display but we already are with a locale assumption. Other option could be for us to geocode live in the app with the user's browser locale.

Are we? you mean we're assuming English? try some of the Eastern European cities for a change in utf8 scenery.

The alternative is for the explorer/app to have a short list of country codes which indicate what geocode fields to pull in?

from explorer.

abhay avatar abhay commented on June 15, 2024

I don't have a strong preference but as we enter more locales, It'd be nice to use the browser's hints to determine how to format.

from explorer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.