show witness distance in poc transactions about explorer HOT 9 CLOSED

Potentially don't bother showing this data for any transactions before block 123479 (when poc_v4_exclusion_cells was set at poc_version = 4) or 200500 (when poc_max_hop_cells was set at poc_version = 8).

from explorer.

Since we check max distance (poc_max_hop_cells) and hex distance (poc_v4_exclusion_cells) we should show those instead?

from explorer.

@abhay what would that way look like in the UI? I'm not too familiar with h3 yet or what those chain vars represent exactly, so I'm not quite sure how I'd implement that or how well it would solve the user problem here. Would that be an overlay on the map? Do you think that's something I could add in addition to the way @cokes518 suggested above?

I was just about to add it the way Coco suggested by converting from h3 to lat/lon and using this function and just printing out the distance when I saw your comment, so not sure how to proceed on this for now.

from explorer.

@danielcolinjames hotspots have an h3 which represents the cell so you want to do distance between h3 indexes at the very least. From there you can see if it's within the range of the chain vars.

from explorer.

@abhay ah okay perfect, I get it now, thank you! I'll see if I can figure out some way to colour it with a success / fail colour without looking awful too...

from explorer.

I'm sure it'll look 💯

from explorer.

Thanks, that's really helpful to know, will do some tests with transactions around those block numbers and see 👍

Also, just to double check, if a distance == 8, it's excluded right? I.e. the rule is: valid = distance > 8 && distance < 2000, rather than >= 8 && <= 2000, right?

(Obviously won't hard code the values)

from explorer.

Please ignore the design of this, just testing locally, but I think I'm going to rearrange the layout of the witness info to something like this:

Also I might have gotten some labels wrong, please let me know if I did. Just trying to make it easier to get all the information in one view, and the long string of numbers was getting a little hard to read. I figure using the full terms is probably better than acronyms too. I might also play with making the witness list for each step expandable, and perhaps collapsed by default...

from explorer.

Also, just to double check, if a distance == 8, it's excluded right? I.e. the rule is: valid = distance > 8 && distance < 2000, rather than >= 8 && <= 2000, right?

valid ~= poc_v4_exclusion_cells <= hex_distance < poc_max_hop_cells

low end: https://github.com/helium/blockchain-core/blob/master/src/poc/blockchain_poc_path_v4.erl#L335-L346
high end: https://github.com/helium/blockchain-core/blob/master/src/poc/blockchain_poc_path_v4.erl#L319-L330

from explorer.