Why not copy the file? about blns HOT 14 CLOSED

.gitmodules is a good choice given that we keep it in sync with the upstream, PR welcome 👍

from blns.

I made PR for this issue, please check it just to be sure.

from blns.

@96AA48 Thanks the submodule part looks fine, but we need to find a way to keep it in sync always readme must be changed and the package.json's file section as well. 👍

from blns.

Sorry for my sloppy coding, I changed the code around so that @chentsulin implementation of require('path/to/blns/json') is in place as well. Will change readme and package.json in a bit.

from blns.

Changed the README and package.json as well, should be ready to merge.

from blns.

I think it can be simplified to something like below:

Module:

'use strict';

module.exports = require('./resources/blns.json');

And test :

'use strict';

var assert = require('assert');
var blns = require('./');

assert(Array.isArray(blns));

Any ideas here?

from blns.

Yeah, that seems to do it as well. Should I make the changes and push them @chentsulin ?

from blns.

Looks fine, but how do we keep it in sync always, maybe using a githook?

git submodule foreach 'git fetch origin --tags; git checkout master; git pull' && git pull && git submodule update --init --recursive

from blns.

I have no experience with things like that, I wish you the best of luck!

from blns.

@96AA48 you can feel free to use any ideas I mention above.

from blns.

Fixed in v2.0.0 thanks 👍

from blns.

Won't this easily fall out of date (it looks like it's 2 years behind already)?

from blns.

What do you suggest?

from blns.

There are a couple options.

1. Implement some sort of automated publish script that always grabs master blns and publishes a new version to npm periodically. Maybe even watch for changes to minimaxir/big-list-of-naughty-strings repo which could trigger the publish.
2. Change it back to how it used to work and perform an HTTP request each run. This will never be out of date. I might suggest using cdn.jsdelivr.net instead of raw.githubusercontent.com but either should work.

from blns.