JVM_OPTS clashes with JAVA_OPTS set by heroku-buildpack-jvm-common about heroku-buildpack-clojure HOT 9 CLOSED

Ack, sorry about this. I think the best thing for us to do in the short term is just remove these two lines from jvm-common:
https://github.com/heroku/heroku-buildpack-jvm-common/blob/master/opt/jvmcommon.sh#L26-L27

Then I'll fix the clojure buildpack so that JVM_OPTS is set dynamically (Just like the other env vars in jvm-common). Does that sound reasonable?

from heroku-buildpack-clojure.

Seems like that would fix our issue. Checking...

from heroku-buildpack-clojure.

Ah... still doesn't work, but that's because https://codon-buildpacks.s3.amazonaws.com/buildpacks/heroku/jvm-common.tgz still has the problematic version of jvmcommon.sh

from heroku-buildpack-clojure.

Oh sorry, yes we have to release it. If you want to give it a try now, you can set this config var (note the "jkutner" part instead of "heroku"):

$ heroku config:set JVM_COMMON_BUILDPACK="https://codon-buildpacks.s3.amazonaws.com/buildpacks/jkutner/jvm-common.tgz"

Let me know if that works, but I'll probably release here in a bit either ways.

from heroku-buildpack-clojure.

I've released the regular default jvm-common, so this should be resolved for you. I'll leave this ticket open and close it when I've fixed JVM_OPTS in this buildpack.

from heroku-buildpack-clojure.

Ok that worked! (that's with custom JVM_COMMON_BUILDPACK)
And thanks for releasing the jvmcommon.

Sounds like I don't need to pass JAVA_OPTS to java ... in Procfile anymore... It should pickup JAVA_TOOL_OPTIONS. Right?

from heroku-buildpack-clojure.

Correct. You could use JAVA_OPTS for things that are specific to your app if need or if you just preferred to keep them out of the Procfile. But otherwise, every Java process will pick up JAVA_TOOL_OPTIONS (with the exception of Java procs in one-off dynos started with heroku run).

from heroku-buildpack-clojure.

I've fixing this by removing JVM_OPTS entirely. It just gets in the way of JAVA_OPTS and JAVA_TOOL_OPTIONS and doesn't provide any advantages.

from heroku-buildpack-clojure.

That makes total sense.

from heroku-buildpack-clojure.