Giter VIP home page Giter VIP logo

Comments (9)

kengoldfarb avatar kengoldfarb commented on July 18, 2024

This might be applicable to the issue...I'm using an empty composer.json file created using the instructions in the README:
echo '{}' > composer.json

The composer.lock file is therefore empty which may be why it's not getting handled properly

from heroku-buildpack-php.

dzuelke avatar dzuelke commented on July 18, 2024

Is your composer.lock completely empty, or does it contain any whitespace, or {} or similar? What operating system is this on?

Was the file generated by Composer, or through some other mechanism, or did you create it by hand?

from heroku-buildpack-php.

dzuelke avatar dzuelke commented on July 18, 2024

If you remove it and run composer update, does it get created again?

from heroku-buildpack-php.

kengoldfarb avatar kengoldfarb commented on July 18, 2024

Completely empty. It looks like composer doesn't generate a composer.lock file when the composer.json is empty.

It's been a while since I set up the project but I probably just did a touch composer.lock so it was there and would be detected as a php app.

from heroku-buildpack-php.

kengoldfarb avatar kengoldfarb commented on July 18, 2024

OSX 10.9.3

Composer version e77435cd0c984e2031d915a6b42648e7b284dd5c 2014-07-02 15:44:54

from heroku-buildpack-php.

kengoldfarb avatar kengoldfarb commented on July 18, 2024

FWIW, if I do:
echo '{}' > composer.lock
...then it will deploy properly.

So, not sure if this is necessarily a bug after all, but v21 didn't complain about an empty composer.lock

from heroku-buildpack-php.

dzuelke avatar dzuelke commented on July 18, 2024

You don't need a composer.lock at all. If you run composer update, Composer will remove it, as your composer.json specifies no package dependencies and thus needs no lock file.

from heroku-buildpack-php.

kengoldfarb avatar kengoldfarb commented on July 18, 2024

Ah, well that's even better 👍

I've been so used to using another buildpack before you added official support I assumed the composer.lock was required. My apologies for all the back and forth.

from heroku-buildpack-php.

dzuelke avatar dzuelke commented on July 18, 2024

Alright, should be all fixed now (5bfe3a5, already released), just in case you ever run into it again. Thanks for the heads-up!

P.S. you can do heroku config:unset BUILDPACK_URL as it'll auto-detect PHP projects and use the official buildpack.

from heroku-buildpack-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.