then/andThen with empty response body about react-refetch HOT 7 CLOSED

Definitely sounds like a bug. The presence of a body should not affect the the post-processing. However I tried a quick unit test, but could not reproduce. Perhaps I'm missing something, but in the meantime, could you see if catch/andCatch work? If they do, is there an error returned?

from react-refetch.

@ryanbrainard catch/andCatch fails with

SyntaxError: Unexpected end of input

With no stacktrace.

from react-refetch.

@neezer Ok, so probably a problem with the JSON parser blowing up and rejecting the promise. What version of whatwg-fetch are you using? Either way, we can handle it in RR, but it wondering why my unit test didn't fail...

from react-refetch.

"whatwg-fetch": "^0.11.0"

from react-refetch.

Hmm, same as me. I can dig in more later. Guessing the problem is in https://github.com/heroku/react-refetch/blob/master/src/components/connect.js#L105-L112 if someone wants to experiment

from react-refetch.

@ryanbrainard That seems like a good guess. Thinking that because response.body stream is empty, the line that reads response.json() is effectively doing something akin to JSON.parse(""), which yields the same error I'm getting.

from react-refetch.

@ryanbrainard Toying around, this fixes the issue for me, though no vote on whether or not this is a good approach (just adding an early return):

function handleResponse(response) {
  if (response.headers.get('content-type') === null)  return;

  var json = response.json(); // TODO: support other response types
  if (response.status >= 200 && response.status < 300) {
    // TODO: support custom acceptable statuses
    return json;
  } else {
    return json.then(function (cause) {
      return Promise.reject((0, _errors2.default)(cause));
    });
  }
}

Perhaps better to gate the JSON parsing based on whether or not the Content-Type is actually application/json.

from react-refetch.