Comments (3)
Hi @martinmodrak ,
Thank you for your feedback. I have the same issue.
The model included a compartment with "default" id.
This is a reserved word in mrgsolve, as I understand.
I've updated the repository with jak2stat5 model changing "default" => "def".
Now everything is fine. Compilation and simulations are OK.
Pull the latest commit from hetalang/qsp-benchmark and recompile the model.
This is a workaround. But the unexpected issues with reserved words are still a problem.
We need a better solution.
from heta-compiler.
Wouldn't a systematic solution be that the XXExport
classes expose a list of keywords and the compiler checks the model against this list. It could then either:
- Raise an error/warning when an id conflicts with the keywords, or
- Automatically rename all ids to avoid the conflict (e.g. by adding underscorses or something)
(I don't insist on this being done for the review, it just seems like a relatively cheap but useful solution)
from heta-compiler.
@martinmodrak, agree, this would be good.
As a fast temporal solution, I've added "default" into a general keyword list.
Now the usage of such id throws an error. A user should change the id of such a component by himself.
But I still doubt if it's the best solution.
- It seems that each "export" type should have its own stop list. We need time to collect and analyze them all.
- We should also think of automatic renaming rules.
So I guess we suggest a better solution later.
from heta-compiler.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heta-compiler.