Feature Request: Duplicate struct as -Opts about hcloud-go HOT 5 CLOSED

Thank you for the follow-up! You're correct, I only went off the documentation because the fields are marked as required. I had not tried submitting JSON for just that one field.

from hcloud-go.

This seems to be specific to the LoadBalancerClient#UpdateService call, I could not find any other update call in the API that requires so many fields to be set, instead of just replacing what was given.

I think it would be a nice addition to implement that in hcloud-go. What do you think @pauhull?

Edit: API Docs reference for "LB Update Service"

from hcloud-go.

Yes, that sounds like a useful improvement to me. I'll be working on an implementation 🙂

from hcloud-go.

I've double checked the issue and can't reproduce it on my side. I am able to update a service's certificates using the following code:

lb, _, _ := client.LoadBalancer.GetByName(context.Background(), "load-balancer-1")

client.LoadBalancer.UpdateService(context.Background(), lb, 443, LoadBalancerUpdateServiceOpts{
    HTTP: &LoadBalancerUpdateServiceOptsHTTP{
        Certificates: []*Certificate{
            {
                ID: cid,
            },
        },
    },
})

Other fields, like the ones you mentioned, do not seem to be affected by that. Did you try leaving them out, and if so, was there any unexpected behavior? Or did you just go off the documenation because the fields are marked as required in there?

from hcloud-go.

We have updated the docs and it will go out with the next deployment. Thank you for reporting this :)

from hcloud-go.