Giter VIP home page Giter VIP logo

Comments (7)

michallepicki avatar michallepicki commented on May 18, 2024

Is this issue about adding the master version link to the dropdown?

Is it also about fixing the links to Elixir v1.0.0 - v1.0.3 or is it a separate issue?

from bob.

ericmj avatar ericmj commented on May 18, 2024

I think we should add master to the dropdown based on other discussions. Do you agree @josevalim?

We don't have docs builds for Elixir v1.0.0 - v1.0.3 so we should remove those links from the dropdown.

from bob.

wojtekmach avatar wojtekmach commented on May 18, 2024

I actually initially had master in the dropdown (5d2fc6b) but then on https://hexdocs.pm/elixir/master/Kernel.html page the dropdown had both 1.9.0-dev and master which was confusing. When building config I could see that the latest tag is v1.8.1 so the next dev version should be v1.9.0-dev and put that into the list with the link to master, but I'm afraid this could be too clever and error prone.

I've removed links for 1.0.0..1.0.3, good catch!

from bob.

josevalim avatar josevalim commented on May 18, 2024

When building config I could see that the latest tag is v1.8.1 so the next dev version should be v1.9.0-dev and put that into the list with the link to master, but I'm afraid this could be too clever and error prone.

This will be fine for a long long long time, at least until we start work on v2.0, so I am ok with it.

from bob.

wojtekmach avatar wojtekmach commented on May 18, 2024

@josevalim just so we're clear, you're saying to add 1.9.0-dev (or whatever the latest dev version is) to the config.js or leave things as is?

from bob.

michallepicki avatar michallepicki commented on May 18, 2024

@wojtekmach I see. You can take a look at my code here - for people hosting their docs and maintaining their own versions, for convenience and so that things don't break, we're prepending the list with an entry for the current version if it's seemingly missing. The current version name is being read from what was displayed instead of the version dropdown, so indeed for the current master it's v1.9.0-dev.

Looks like having an option v1.9.0-dev is the easy way to go for now, I actually don't mind if it would be called that. We could change my code in ExDoc if we want to display master there

from bob.

josevalim avatar josevalim commented on May 18, 2024

leave things as is?

This. :)

from bob.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.