Giter VIP home page Giter VIP logo

Comments (6)

HeyAnirudh avatar HeyAnirudh commented on July 21, 2024 1

yes

could you assign this to me please?

done!

Thank you! I was about to start working on it but before that I noticed that there was a problem with running the app: My computer is running Linux, and as such, when it tries to run the app, it does not find the hard coded values: 'C:\\Users\\Admin\Desktop\\github\\certificates_streamlit\\pics\\apricus.png') and "images\\img.png")
because the way linux organises the file system is a bit different (ie there is no C drive for example).
Before I try and fixing the fonts issue, may I open a separate Pull Request and try changing these hardcoded values using the python OS module, abstracting these hard coded values so that the app runs on Mac OS, Linux,and windows with no problems?

thank you @Beatrix-droid for pointing out the issue, and yes could you open a pull request but not before the 15th.

My apologies, I had some spare time this morning, and unfortunately have already fixed the issue and created a PR. This was before you replied to me. If you'd like you can close the PR, and I can make another identical PR on the 15th :)

yes

could you assign this to me please?

done!

Thank you! I was about to start working on it but before that I noticed that there was a problem with running the app: My computer is running Linux, and as such, when it tries to run the app, it does not find the hard coded values: 'C:\\Users\\Admin\Desktop\\github\\certificates_streamlit\\pics\\apricus.png') and "images\\img.png")
because the way linux organises the file system is a bit different (ie there is no C drive for example).
Before I try and fixing the fonts issue, may I open a separate Pull Request and try changing these hardcoded values using the python OS module, abstracting these hard coded values so that the app runs on Mac OS, Linux,and windows with no problems?

thank you @Beatrix-droid for pointing out the issue, and yes could you open a pull request but not before the 15th.

My apologies, I had some spare time this morning, and unfortunately have already fixed the issue and created a PR. This was before you replied to me. If you'd like you can close the PR, and I can make another identical PR on the 15th :)

hey instead delete the pr and make this an issue and self-appoint it, it would be even better. ill share the format of creating a issue in the discord soon.

from certificate-generator.

Beatrix-droid avatar Beatrix-droid commented on July 21, 2024

could you assign this to me please?

from certificate-generator.

HeyAnirudh avatar HeyAnirudh commented on July 21, 2024

could you assign this to me please?

done!

from certificate-generator.

Beatrix-droid avatar Beatrix-droid commented on July 21, 2024

could you assign this to me please?

done!

Thank you! I was about to start working on it but before that I noticed that there was a problem with running the app:
My computer is running Linux, and as such, when it tries to run the app, it does not find the hard coded values:
'C:\\Users\\Admin\Desktop\\github\\certificates_streamlit\\pics\\apricus.png')
and
"images\\img.png")

because the way linux organises the file system is a bit different (ie there is no C drive for example).

Before I try and fixing the fonts issue, may I open a separate Pull Request and try changing these hardcoded values using the python OS module, abstracting these hard coded values so that the app runs on Mac OS, Linux,and windows with no problems?

from certificate-generator.

HeyAnirudh avatar HeyAnirudh commented on July 21, 2024

yes

could you assign this to me please?

done!

Thank you! I was about to start working on it but before that I noticed that there was a problem with running the app: My computer is running Linux, and as such, when it tries to run the app, it does not find the hard coded values: 'C:\\Users\\Admin\Desktop\\github\\certificates_streamlit\\pics\\apricus.png') and "images\\img.png")

because the way linux organises the file system is a bit different (ie there is no C drive for example).

Before I try and fixing the fonts issue, may I open a separate Pull Request and try changing these hardcoded values using the python OS module, abstracting these hard coded values so that the app runs on Mac OS, Linux,and windows with no problems?

thank you @Beatrix-droid for pointing out the issue, and yes could you open a pull request but not before the 15th.

from certificate-generator.

Beatrix-droid avatar Beatrix-droid commented on July 21, 2024

yes

could you assign this to me please?

done!

Thank you! I was about to start working on it but before that I noticed that there was a problem with running the app: My computer is running Linux, and as such, when it tries to run the app, it does not find the hard coded values: 'C:\\Users\\Admin\Desktop\\github\\certificates_streamlit\\pics\\apricus.png') and "images\\img.png")
because the way linux organises the file system is a bit different (ie there is no C drive for example).
Before I try and fixing the fonts issue, may I open a separate Pull Request and try changing these hardcoded values using the python OS module, abstracting these hard coded values so that the app runs on Mac OS, Linux,and windows with no problems?

thank you @Beatrix-droid for pointing out the issue, and yes could you open a pull request but not before the 15th.

My apologies, I had some spare time this morning, and unfortunately have already fixed the issue and created a PR. This was before you replied to me.
If you'd like you can close the PR, and I can make another identical PR on the 15th :)

from certificate-generator.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.