Giter VIP home page Giter VIP logo

Comments (16)

xavizardKnight avatar xavizardKnight commented on June 16, 2024 2

@Kirylchyk @alexcochran Heyas! I want to start advancing with the US subdivision flags, now that the subdivision flags of Spain are done, and I've seen that both of you have contributed some recently. Have you done any more advancements on other flags? Can I continue on working on the remaining flags?

from openmoji.

maxterry avatar maxterry commented on June 16, 2024 2

Nice to see some momentum on this! Would be great to work toward a complete set of U.S. subdivision flags eventually, no preference from my side on order/priority to get there.

from openmoji.

Kirylchyk avatar Kirylchyk commented on June 16, 2024 1

hey @maxterry, I picked up and started to work on this enhancement. #489 was merged to add Washington DC flag emoji. I am aware of the following flags https://en.wikipedia.org/wiki/Category:United_States_state_flags and planning to add flags at the reasonable pace. Do you have any order preferences? Thank you

from openmoji.

Kirylchyk avatar Kirylchyk commented on June 16, 2024 1

hey @xavizardKnight that's awesome! Indeed, i'm working on some more emoji. Lets split

from openmoji.

Kirylchyk avatar Kirylchyk commented on June 16, 2024 1

let's split the list 50/50

from openmoji.

alexcochran avatar alexcochran commented on June 16, 2024 1

from openmoji.

xavizardKnight avatar xavizardKnight commented on June 16, 2024 1

The hidden grid was not intentional; i just don't think I noticed it was different than the others during development. I'd be happy to work on some more of the US states collaboratively.

Don't worry. I'll do now a quick PR readding the grid, it's a quick fix.

let's split the list 50/50

We can split the remaining list in 3 parts; then all 3 we can contribute.

from openmoji.

Kirylchyk avatar Kirylchyk commented on June 16, 2024 1

agree, i have no preferences.

By now, i'm working on:
[Flags of Alabama](https://en.wikipedia.org/wiki/Category:Flags_of_Alabama)‎ (1 C, 1 P)
[Flags of Utah](https://en.wikipedia.org/wiki/Category:Flags_of_Utah)‎ (1 C, 1 P)

And then we can split, what is left

from openmoji.

Kirylchyk avatar Kirylchyk commented on June 16, 2024 1

@alexcochran @xavizardKnight fyi opened PR for Alabama flag ->

Reference 1: #497
Reference 2: https://en.wikipedia.org/wiki/Flag_of_Alabama

Thx!

from openmoji.

xavizardKnight avatar xavizardKnight commented on June 16, 2024 1

alexcochran xavizardKnight fyi opened PR for Alabama flag

Nice!

I've been starting to experiment with the Hawaii, Arizona, Washington (state, not DC), Ohio and Montana flags. They look a bit tricky, and I like challenges, so I'm playing with them to see what I can do.

We really should create a list or something so we can see who does what and what remains…

Also, it would be nice to not create one PR per flag; let's make all of us one PR per person with all the US subdivision flags when we finish them all. Otherwise, there will be a lot of small PRs.

from openmoji.

xavizardKnight avatar xavizardKnight commented on June 16, 2024

hey @xavizardKnight that's awesome! Indeed, i'm working on some more emoji. Lets split

Yeah! If you started some, give me the list of those you haven't started yet. Or let's split the list 50/50 and start working from there, as you prefer.

Nice to see some momentum on this! Would be great to work toward a complete set of U.S. subdivision flags eventually, no preference from my side on order/priority to get there.

We can try to aim and see if we can complete all the US subdivision flags before the next OpenMoji release; there are quite a few flags, and some of them are pretty complex, but I think we can manage to pull it off.
Don't know when it will be the next release, but probably by the end of this year.

from openmoji.

xavizardKnight avatar xavizardKnight commented on June 16, 2024

Also, I've realised that the recently added Colorado flag has no grid layer in its source file. Technically, it does have a grid layer, but it's hidden. This doesn't seem to affect the outputs, but it looks weird in comparison with the rest of the flags when viewing the thumbnails of the folder. Was this intentional?

2024-04-09_19-43

from openmoji.

Kirylchyk avatar Kirylchyk commented on June 16, 2024

i would prefer to keep each flag per one separate commit

from openmoji.

b-g avatar b-g commented on June 16, 2024

Super that the two of you starting to tackle this! Great!

Small note: I would prefer less PRs than for every single flag a dedicated PR. Generating and checking is quite some work. Sorry! OpenMoji is quite heavy ...

from openmoji.

Kirylchyk avatar Kirylchyk commented on June 16, 2024

Gotcha, i'll try to combine several flags in one PR. I would prefer to work on my own branch at my pace. Thank you

from openmoji.

b-g avatar b-g commented on June 16, 2024

@Kirylchyk Great! Many thanks!

from openmoji.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.