Comments (9)
I managed to fix this by replacing the zend_stream_getc line with the actual function from zend_stream.c
However it then complains about undefined symbol zend_error_noreturn, I replaced this with zend_error and it worked.
from xhp-lib.
Thanks. I had the same problem. This worked for me!
from xhp-lib.
What platform / gcc version are you guys using? I can't reproduce this on PHP 5.3.1 even though looking at the code it doesn't make sense that it works.
from xhp-lib.
CentOS 5.4 i386 and x86_64, I modified the Fedora SRPMs to build php 5.3.1
gcc version 4.1.2-46
from xhp-lib.
So I understand this bug, but I can't pinpoint why I can't reproduce it. zend_stream_getc is defined as static in zend_stream.c, but somehow it has no problems compiling on my system (and a lot of other systems). I can copy the code like you mentioned but I'm worried that without figuring out why it works on my system and not yours we may run into more bugs like this in the future.
from xhp-lib.
Well I managed to repro using gcc 4.1 like you mentioned, but I don't get the zend_error_noreturn failure. @crowsfan85, do you get the zend_error_noreturn not defined error as well, or is it just zend_stream_getc?
from xhp-lib.
I seem to no longer get that zend_error_noreturn error, whether it was me changing the CPPFLAGS in my build scripts or upgrading to php 5.3.2
So the gcc version, I assume you've been building earlier with later versions of gcc? It seems strange that they should add dodgy unexported function linking as a feature to gcc.
from xhp-lib.
Strange indeed. static is more of just a guideline so I think the compiler can just do whatever it wants, and once you give it -O2 or -O3 all assumptions are out the window. I'll be sure to test in gcc 4.1.x for future releases.
from xhp-lib.
Fixed with 8698ead
from xhp-lib.
Related Issues (20)
- Remove XHPRoot, seal `x:node`/composable-element to x:primitive and x:element HOT 5
- [ Todo ] When XHP version 4 is released, update the docs about runtime validation in user-documentation. HOT 2
- Remove class2element/element2class
- Audit all code that is not in namespaces HOT 1
- Do we want the HTML xhp classes to be final in v4?
- [ RFC ] Introduce a new exception class for modifying/rendering xhp after initial render HOT 1
- Remove string selectors from getFirstChild and friends
- Audit missing category declarations HOT 4
- Rewrite docs on user-documentation to use xhp 4 syntax and rules HOT 2
- Make a full list of changes from v3
- Write a migration guide for v3 -> v4
- better exception message when rendering parent with an already rendered child HOT 8
- Review and consider removing all 'deprecated' features HOT 1
- Update README to reflect xhp-4
- hhvm 4.97 issue: x\node should permit ?XHPChild children HOT 2
- Class Undefined xhp-lib v3 HOT 9
- Use of XHP at Facebook HOT 2
- Default values of aria- and data- attributes are ignored
- [Request] Custom special attributes HOT 4
- Status of the project HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xhp-lib.