PHP 5.3.1 build undefined symbol zend_stream_getc about xhp-lib HOT 9 CLOSED

I managed to fix this by replacing the zend_stream_getc line with the actual function from zend_stream.c

However it then complains about undefined symbol zend_error_noreturn, I replaced this with zend_error and it worked.

from xhp-lib.

Thanks. I had the same problem. This worked for me!

from xhp-lib.

What platform / gcc version are you guys using? I can't reproduce this on PHP 5.3.1 even though looking at the code it doesn't make sense that it works.

from xhp-lib.

CentOS 5.4 i386 and x86_64, I modified the Fedora SRPMs to build php 5.3.1

gcc version 4.1.2-46

from xhp-lib.

So I understand this bug, but I can't pinpoint why I can't reproduce it. zend_stream_getc is defined as static in zend_stream.c, but somehow it has no problems compiling on my system (and a lot of other systems). I can copy the code like you mentioned but I'm worried that without figuring out why it works on my system and not yours we may run into more bugs like this in the future.

from xhp-lib.

Well I managed to repro using gcc 4.1 like you mentioned, but I don't get the zend_error_noreturn failure. @crowsfan85, do you get the zend_error_noreturn not defined error as well, or is it just zend_stream_getc?

from xhp-lib.

I seem to no longer get that zend_error_noreturn error, whether it was me changing the CPPFLAGS in my build scripts or upgrading to php 5.3.2

So the gcc version, I assume you've been building earlier with later versions of gcc? It seems strange that they should add dodgy unexported function linking as a feature to gcc.

from xhp-lib.

Strange indeed. static is more of just a guideline so I think the compiler can just do whatever it wants, and once you give it -O2 or -O3 all assumptions are out the window. I'll be sure to test in gcc 4.1.x for future releases.

from xhp-lib.

Fixed with 8698ead

from xhp-lib.