[FEATURE REQUEST] redis client version compatibility about asynq HOT 9 CLOSED

I don't fully understand your question. Asynq uses go-redis/v9. Afaik, the tests pass and everything works fine.

However if you are reusing a go-redis connection for asynq, you need to set it up correctly.

from asynq.

@kamikazechaser
Thank you for your reply!
Let me improve my question:
In our project, this will report an error when using NewClient(r RedisConnOpt). The reason for the error is that r.MakeRedisClient() returns a go-redis/v8 client, which cannot be converted into redis.UniversalClient in go-redis/v9.

from asynq.

Could you additionally post the code on your end to reproduce this issue.

from asynq.

Possibly related to #790

from asynq.

This panic is inevitable.
This is my pseudo-code:

package main

import (
	"github.com/hibiken/asynq"  // v0.24.1 
	"github.com/go-redis/redis/v8"
)

type XRDS struct {
	*redis.Client
}

func (xrds *XRDS) MakeRedisClient() interface{} {
	return xrds
}

func NewRedisClient() *XRDS {
	c := redis.NewFailoverClient(&redis.FailoverOptions{
		MasterName:    "mymaster",
		SentinelAddrs: []string{"x.x.x.x:16379", "x.x.x.x:16379", "x.x.x.x:16379"},
		Password:      "xxxxxx",
		DB:            1,
	})
	return &XRDS{Client: c}
}

func main() {
	_ = asynq.NewClient(NewRedisClient())
}

from asynq.

"github.com/go-redis/redis/v8"

Use go-redis/v9 with v0.24.1 and let me know if the issue still persists. I see that you are not using the x module which is problematic right now.

from asynq.

Yes, we can't go wrong with go-redis/v9.
What I want to ask is, does asynq need to support multiple go-redis versions?

from asynq.

What I want to ask is, does asynq need to support multiple go-redis versions?

No. We want to stick with v9 only. You can track some changes on the sohail/go-update branch which removes the last mention of go-redis/v8 from the x module.

from asynq.

Well, thank you for your answer.

from asynq.