Make knife-zero play nice with ssh config files about knife-zero HOT 10 CLOSED

Seems like this comes from either net-ssh-multi or net-ssh-gateway not knowing about net-ssh's ability to parse ssh_config files:
https://net-ssh.github.io/ssh/v2/api/classes/Net/SSH/Config.html

from knife-zero.

Sample of how knife properly deals with ssh_config by default:
https://github.com/chef/chef/blob/d8172e646d9fbf43e57bca5e20d0ac352ba9a66a/lib/chef/knife/ssh.rb#L213

from knife-zero.

Hm. I see that that's done for bootstrap, but I think there's some confusion, as Net::SSH.configuration_for returns a hash with a :user and :port key, and it appears the current code assumes it would be at :ssh_user and :ssh_port

I unfortunately don't have time to sort this out for my current project, but I'll try to come back later and submit a PR :)

from knife-zero.

Also, any reason bootstrap and chef_client subcommands couldn't share more ssh config info?

from knife-zero.

Thank you for your report, It's a bug.
I want to fix it if possible.

from knife-zero.

I see that that's done for bootstrap, but I think there's some confusion, as Net::SSH.configuration_for returns a hash with a :user and :port key, and it appears the current code assumes it would be at :ssh_user and :ssh_port

Ahh.. That makes sense!

from knife-zero.

I noticed that I have to change ssh_user 'root' to nil by default. hmm...

from knife-zero.

Related(loose) : chef/chef#4038

from knife-zero.

@patcon
Maybe this issue will be solved with...

• knife-zero-1.9.0.pre.1
  • remove default ssh_user.
• chef 12.5 (not released yet)
  • load ssh config file at Chef::Knife::SSH#session_options

from knife-zero.

chef 12.5 and knife-zeto 1.9.0 has released. close for now.

And hand over baton to #48

from knife-zero.