Allow customization of node's client.rb via bootstrap_context about knife-zero HOT 12 CLOSED

fwiw, it seems automatic_attribute_whitelist needs at least ["fqdn/"] in order for knife-zero to continue to work. But this is probably a minimum, so that the knife node show NAME is still maximally populated:

# client.rb
automatic_attribute_whitelist [
  "fqdn/",
  "ipaddress/",
  "roles/",
  "recipes/",
  "ipaddress/",
  "platform/",
  "platform_version/",
]

from knife-zero.

Oh hey, this can be done here:
https://github.com/opscode-cookbooks/chef-client

But hey, I'll leave this open in case you want to have a simple flag in knife.rb that quiets down all the noisy linux automatic attrs.

from knife-zero.

I see. Thank you for good report of use case!

from knife-zero.

Note: I've catched up similar feedback from twitter. https://twitter.com/masudaK/status/608555090165776384

from knife-zero.

https://github.com/chef/chef/blob/59da09f64b72dbd712c890f999322493a4bc9ec4/lib/chef/knife/core/bootstrap_context.rb#L64

client.rb is made by .config_content . I'm going to append content by around_alias.

Which do you think is better? @patcon @rmoriz

• be able to append free format content to client.rb.
• create new option such as --[no-]suppress-attributes for add whitelist automatically.
• create new options such as --attribute_whitelist, attribute_blacklist as Array.

from knife-zero.

hmm... how about #43 ?

from knife-zero.

Hm. I realize I made the request, but I'd actually moved away from the idea of using the whitelist (unless they add negating and make a blacklist possible). So much node information seems to be lost unless the whitelist is VERY extensive, which strikes me as very hard to manage (different platforms have different top-level keys for automatic attrs, etc.)

Perhaps this is best implemented as a recommended wrapper cookbook around one of the blacklist attrs cookbooks mentioned in chef/chef#3533?

from knife-zero.

I'm going to close this for now, as you've created a feature that addresses the initial request, and my new preferred way approach will be done outside this project :)

Thanks @sawanoboly, and sorry for the confusion!

from knife-zero.

(Let me just add my notes, which may help other people having the same issue:

I was manging the node.json files manually (coming from a knife-solo setup) and initially had the same issue until I found out, that knife node edit <name> removes a lot of the clutter before opening the editor. This fits my use case, as I'm happy to store everything in git.)

from knife-zero.

@patcon
Thanks, I also seemed blacklist approach is better. ( discussed in chef/chef#3533 )

Apart from that, I thought also likely case useful to append whitelist, so I implemented it.

from knife-zero.

@rmoriz Yes, It's kind of use case 😃

from knife-zero.

Rockin :)

And thanks @rmoriz! That's actually really helpful for our workflow! I hadn't put two and two together on that

from knife-zero.