Comments (13)
Done, @akollegger and @joshgoebel.
from highlightjs-cypher.
@akollegger Could I get a link to a GitHub issue or a thread of this problem? Minor versions don't typically "break" themes - though sometimes highlighting does change slightly - which could require a theme to be updated. Otherwise I'm also not sure how bumping a dependency here would have any effect on your theme at all?
from highlightjs-cypher.
"highlightjs": "^9.10.0",
Ok, that is OLD... all bets are off... I take back what I said. :-) it's possible something may indeed need to change if this hasn't been updated since version 9.
from highlightjs-cypher.
I'll fix it this afternoon. Please forgive us for the inconvenience.
from highlightjs-cypher.
Still quite curious how a theme was broken though, grammar itself looks pretty clean - so surprises.
from highlightjs-cypher.
The break surfaced as an unsatisfied dependency. It appeared that highlightjs-cypher
requires highlightjs
but the newer version is highlight.js
.
from highlightjs-cypher.
It appeared that highlightjs-cypher requires highlightjs but the newer version is highlight.js.
Ah yes the correct package name is now highlight.js
, the older name was deprecated a year or more ago.
from highlightjs-cypher.
Thanks @gusbemacbe !
I think we should probably release version 2.0.0 since it's a major bump? What do you think?
from highlightjs-cypher.
Thanks @gusbemacbe !
I think we should probably release version 2.0.0 since it's a major bump? What do you think?
Do you mean to create a new release here?
from highlightjs-cypher.
Do you mean to create a new release here?
Actually, it's a development dependency so I'm a bit confused...
The break surfaced as an unsatisfied dependency. It appeared that highlightjs-cypher requires highlightjs but the newer version is highlight.js.
@akollegger could you please post the complete error message?
from highlightjs-cypher.
Apologies, you're right that the dependency was not the root cause for my theme. The theme initialization api changed, which incidentally failed on requiring highlightjs-cypher
but had to do with asset loading and not a problem with highlightjs-cypher
itself.
-ABK
from highlightjs-cypher.
The theme initialization api changed,
I wasn't aware we have any sort of API for themes?
from highlightjs-cypher.
Outdated issue.
from highlightjs-cypher.
Related Issues (9)
- Action required: Greenkeeper could not be activated 🚨 HOT 1
- Some of your readme tags are broken images/links. HOT 2
- Contribute to the thought process for 3rd party language packaging if you'd like HOT 55
- Request: Add a LICENSE file, please. HOT 3
- Add a rule for inline comment HOT 2
- Alias with backtick should be a string HOT 2
- Add call as a keyword HOT 6
- Document how to generate the dist file HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from highlightjs-cypher.