Please update your README and bundle a `dist` build. about highlightjs-extempore HOT 11 CLOSED

Hey @joshgoebel thanks for the heads up. @cyblue9 and I will get on it asap.

from highlightjs-extempore.

Hi @joshgoebel

I tried to update.
Updated branch is below.

https://github.com/highlightjs/highlightjs-extempore/tree/feature/update_latest_spec

Please review.
If it is nothing problem, I merge this branch to main branch.

from highlightjs-extempore.

I'd recommend changing:

<script type="text/javascript" src="/path/to/highlightjs-extempore/dist/extempore.min.js"></script>

to

<script type="text/javascript" src="/path/to/extempore.min.js"></script>

Someone using the file directly is likely to just by copying it or moving it (alone) into a better location, using it with the entire git checkout would be kind of strange - though I suppose you could do it. I'll leave changing it up to you, but I think I'd try to encourage someone to use just the single file vs deploying the whole repository to their project.

from highlightjs-extempore.

N/m, now I see my own sample repo does this - though it's still bugging me - but I can't believe I haven't noticed till now. :) I'm going to give it more thought. :) Your call.

from highlightjs-extempore.

Hey @joshgoebel I don't think I have a strong opinion on this, although I do think that just copying in the minified file is probably easier & nicer than having to copy the whole directory. So unless there's some reason that you're keeping the "copy whole directory" instructions, we'll probably just do it the way you (initially) suggested. What do you reckon?

from highlightjs-extempore.

So unless there's some reason that you're keeping the "copy whole directory" instructions

Well there are no instructions like that. :) It's just implied. :-) I'm going to change it now.

from highlightjs-extempore.

highlightjs/highlightjs-robots-txt@2c9d6e0

from highlightjs-extempore.

Hi @joshgoebel

I changed README.md by referring to highlightjs/highlightjs-robots-txt@2c9d6e0.
Is it OK?

https://github.com/highlightjs/highlightjs-extempore/tree/feature/update_latest_spec

from highlightjs-extempore.

Btw I'll probably remove that "see how Ben does it on his blog" comment in the readme once this change lands, because this new way is better. But let's just get this thing figured out first.

from highlightjs-extempore.

Looks good at a glance!

from highlightjs-extempore.

@joshgoebel @benswift

Thank you for checking!
I've fixed Ben's point and merged it into the main branch.

from highlightjs-extempore.