Treat clippy warnings as errors. about spidermonkey_runtime HOT 6 CLOSED

i fixed the warnings, i'll leave it up to you to close this issue if you added all you want to the workflow files

Thanks for the insight in how to use Clippy! 👍

from spidermonkey_runtime.

I added all in 5df38a1

from spidermonkey_runtime.

Maybe adding #![deny(warnings)] and #![deny(clippy)] would be better idea, because it would produce errors even outside CI (your pc). So less failed builds.

from spidermonkey_runtime.

i don;t know exacly what you mean by that..

i run clippy a lot also on my pc (using 'cargo clippy') and while that does not give errors i sometimes get errors in CI

from spidermonkey_runtime.

On your PC you need to run clippy with -- -D warnings or maybe RUSTFLAGS: -D warnings to threat warnings as errors. Maybe prepush hook could make more successful builds.

from spidermonkey_runtime.

added a ref to husky, this will generate git-hooks when you run cargo test

from spidermonkey_runtime.