Giter VIP home page Giter VIP logo

Comments (3)

andrieshiemstra avatar andrieshiemstra commented on June 23, 2024

see
https://doc.servo.org/mozjs/jsapi/fn.SetModuleDynamicImportHook.html
https://doc.servo.org/mozjs/jsapi/type.ModuleDynamicImportHook.html

https://github.com/servo/servo/blob/2ce4bc5ad6687ad37bd928709eae1be866b5abc8/components/script/script_module.rs#L1133

from spidermonkey_runtime.

andrieshiemstra avatar andrieshiemstra commented on June 23, 2024

dyn import gets us err: "Dynamic module import is disabled or not supported in this context"
because we need to set the dynamic import hook

https://searchfox.org/mozilla-central/source/js/src/builtin/ModuleObject.cpp#1755

from spidermonkey_runtime.

andrieshiemstra avatar andrieshiemstra commented on June 23, 2024

ok, basic code works, next up

  • code quality
    • i'm doing a lot uf unnecesarry rooting to get the types i need
    • impl epr.handle()
    • figure out or create util for jsapi::handle -> rust::handle
    • epr for JSString/Value and not just object
    • replace closure with three seperate epr's?`
    • move to modules.rs as much as possible and make the util reusable
  • documentation
  • test cases
    • cached and uncached
    • unresolvable, see if prom rejects
    • unparsable, see if prom rejects

from spidermonkey_runtime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.