Giter VIP home page Giter VIP logo

Comments (3)

inkydragon avatar inkydragon commented on June 27, 2024

There are decisions to be made:
I don't know what your opinion is, so let's discuss it first.

  • STEP 3: remove GnuWin32/patch dependency, switch to git apply
  • STEP 4: MSVC in C mode doesn't have stdatomic.h.
  • STEP 5: Do not clean up output libs.
    • Exclude the correct dir: clean -df -e build => clean -df -e out (minimum modify)
    • replace all /out/ with /build/
      Many projects use build as the default compile output folder and add it to the .gitignore file.
      Otherwise, git will complain that many submodules are dirty.
    • Do not clean temp files.

from nanoem.

hkrn avatar hkrn commented on June 27, 2024

STEP 3: remove GnuWin32/patch dependency, switch to git apply

I'll fix it.

STEP 4: MSVC in C mode doesn't have stdatomic.h

libsoundio is an optional dependency (built for GLFW application in glfw directory and can disable by NANOEM_DISABLE_BUILD_GLFW environmnet variable) and disable it by NANOEM_DISABLE_BUILD_LIBSOUNDIO environment variable. The WASAPI based audio player implementation is used in Windows native application (in win32 directory) and there is not reason to build libsoundio unless GLFW based application is built.

STEP 5: Do not clean up output libs.

The default behavior is built to out directory for each dependencies, this can be controlled by NANOEM_BUILD_DEPENDENCIES_DIRECTORY and FX9_BUILD_DEPENDENCIES_DIRECTORY environment variables and set them to outside of nanoem source directory.

NANOEM_BUILD_DEPENDENCIES_DIRECTORY and FX9_BUILD_DEPENDENCIES_DIRECTORY are used in GitHub CI workflow.

For historical reasons, build directory was used as artifact directory and ignore it, It's now out directory therefore built artifact will be purged by cleanup_all_repositories. This is unintentional behavior and will be fixed by changing built to out directory.

from nanoem.

stale avatar stale commented on June 27, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

from nanoem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.