Add support for TypedArrays about piexifjs HOT 7 OPEN

According to this chart, all modern browsers (not just major) fully support TypedArray. Even IE >=10 supports everything except Uint8ClampedArray, but I can just use Uint8Array to include IE 10 support.

And according to this other chart, Node.js has fully supported TypedArray since 0.12, which is very old. The only features unsupported were the ones pertaining to TypedArray and ES6 syntax, which obviously didn't gain support until around 4.0, but that can easily be avoided in an implementation.

from piexifjs.

Yeah! Thank you!
We need only Uint8Array. I think so, too.
This library should be implemented.

from piexifjs.

Thanks for suggestion.

If latest stable browsers and nodejs support for TypedArrays, I decide to support for TypedArrays. When I started this library, browsers didn't support for it.

I think that this library should choose "just check the type of the input and act accordingly".

from piexifjs.

Glad this is on your radar. We've found at BeFunky that FileReader.readAsBinaryString can be unreliable (it's deprecated in favor of FileReader.readAsArrayBufferand sometimes fails in Chrome on Mac), and FileReader.readAsDataURL (base64) is slow.

Supporting Uint8Array would allow us to use FileReader.readAsArrayBuffer which is both fast and reliable in all browsers.

from piexifjs.

This would potentially also opening up for minimal reading: only reading file data incrementally up until the exif data ends. Currently one has to make an educated guess at a decent max size to stop reading, like mentioned here.

from piexifjs.

I second this suggestion and say that TypedArrays became widely used facility to handle byte data. The support for it is almost universal nowadays.
Any plans to adding support for it?

from piexifjs.

@mheskol This library is dead, ref #78. If you need the functionality, start a fork, implement and publish it to NPM to to share it with the world 🚀 If you do not need write-support, ExifReader is in active development and is maintained.

from piexifjs.