Giter VIP home page Giter VIP logo

Comments (5)

bertsky avatar bertsky commented on August 22, 2024

309b83c

thanks!

Hmm, it does work for image-only fileGrps now, but still happens if some fileGrp misses a pageId (as soon as I step to that page). Re-open or new issue?

from browse-ocrd.

hnesk avatar hnesk commented on August 22, 2024

Ah, ok. So the fileGrp has no PAGE-XML entry for a particular page_id, right?

from browse-ocrd.

bertsky avatar bertsky commented on August 22, 2024

So the fileGrp has no PAGE-XML entry for a particular page_id, right?

Exactly! (Happens when using -g selectively during processing, or adding pages to a workspace later-on.)

from browse-ocrd.

hnesk avatar hnesk commented on August 22, 2024

Can you check with the latest commit fd02515 ?
I found it difficult to reproduce a crash, I tried it here

def test_page_for_id_with_nothing_for_page_and_fileGrp(self):

so I'm not sure if this is the fix.

Browsing to a fileGrp without PAGE-XML should now give you a warning:
11:04:37.785 WARNING ocrd_browser.model.document - No PAGE-XML and no image for page 'PHYS_0020' in fileGrp 'OCR-D-GT-PAGE'
and that should be it.

If the problem still persists, an example workspace would be nice.

from browse-ocrd.

bertsky avatar bertsky commented on August 22, 2024

Can you check with the latest commit fd02515 ?

Yes, this works perfectly – thanks a lot!

I found it difficult to reproduce a crash, I tried it here

def test_page_for_id_with_nothing_for_page_and_fileGrp(self):

Indeed, this is a correct way to simulate missing pages. (You also could have created that workspace dynamically, by removing the page ad-hoc in the test, but never mind.)

Browsing to a fileGrp without PAGE-XML should now give you a warning:

It does exactly that.

from browse-ocrd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.