Form`s values does not update when change initialValues about smalldots HOT 4 CLOSED

Hum, yeah, it's a bug, but that's not the correct fix.

Say for example the form mounted with the following initialValues:

{ name: 'Héliton', age: '26' }

Then the user changed age to 27:

{ name: 'Héliton', age: '27' }

For some reason, you change initialValues to:

{ name: 'Harry', age: '28' }

From my point of view, as name is not dirty, it should be changed to Harry, and age should remain 27, because it's dirty, the user changed it.

In a nutshell, when you update initialValues only pristine values should receive the update.

What do you think?

from smalldots.

Yes, it makes sense. So what is the solution to this bug?

from smalldots.

Probably something like:

componentWillReceiveProps(nextProps) {
  if (isEqual(nextProps.initialValues, this.props.initialValues)) {
    return
  }
  this.setState(prevState => {
    const dirtyValues = (
      Object.keys(prevState.values)
        .filter((path) => this.isDirty(path))
        .reduce((result, path) => ({
          ...result,
          [path]: prevState.values[path],
        }), {})
    )
    return {
      values: {
        ...nextProps.initialValues, 
        ...dirtyValues,
      }
    }
  })
}

Can you test please?

from smalldots.

Please test with deep paths too, e.g. a.deep.path[0].foo.bar

from smalldots.