Giter VIP home page Giter VIP logo

Comments (2)

NickCondron avatar NickCondron commented on July 30, 2024

This is really good. Don't see a need to lump anything together. Determining if a given ground id is part of the main stage would be a function. 65535 is just -1 in two's complement reinterpreted as an unsigned integer, so probably the spec (and by extension peppi) have that type incorrectly marked as unsigned.

If you want to add this to peppi, I think you could model the code after what I did to include costumes (#9) which was modelled after how action_state::State works. You could create a function like is_main_stage() like how I did for the costume color functions here 918b850 (decided not to add to peppi, but the technique would be the same I think). Macros can be finnicky though so if you decide to work on this and need help lmk.

Ideally, we'd have a more thorough list of all the ground IDs for all stages. I understand this is a lot of work though. Perhaps the data could be automatically extracted from the Gr*.dat files in melee's code. In any case, you'd want to design the code such that expanding the known list of ground IDs would not be a breaking change.

from peppi.

hohav avatar hohav commented on July 30, 2024

Moved to ssbm-data#3.

from peppi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.