rename `before` and `after` in the definitions about definitions HOT 6 CLOSED

@ttwo32 Oh wow, good idea! For some reason that never even occurred to me. Including it in holidays/holidays#339 would make a lot of sense. I wasn't planning on bumping the ruby gem immediately anyway so this will work out great.

Just so everyone is clear, this change would require a major version bump for the definitions to v5.0.0. Which is just fine by me!

I'll assign it to myself. I don't have a delivery estimate yet but I commit to providing some kind of update by end of day Saturday February 16th.

Thanks again for this feedback and suggestion @iGEL. 🎉

from definitions.

I just merged the PR containing these changes. I will be opening the matching ruby PR shortly.

Thank you for the original issue @iGEL! I really feel like this is an improvement over what we had in the past. 🎉

from definitions.

This seems like a great idea! I personally like this better.

@ttwo32 I believe you are the one that originally added this feature, do you have any feedback?

from definitions.

@iGEL Sorry for late response.
Good idea!! This is better than original. :)

@ppeble This is good. :)
Include in the next release?

from definitions.

@iGEL @ttwo32 For once in my life I am coming in way, way ahead of my promised deadline! I opened a PR that addresses this from the definitions side: #125

If we think that this looks good then I will make the necessary changes to the ruby repository to use the updated keys. Let me know what you think!

from definitions.

Here is the matching ruby repository PR for posterity: holidays/holidays#347

from definitions.