Comments (3)
ppeble
commented on September 25, 2024
1
Hi @ste26054, sorry for the delay! A new PR with the proposed changes would be perfect if you are willing!
In regards to your question about Orthodox Good Friday, we do have a method for orthodox_easter that we generally use to calculate Good Friday. In general terms we use Easter as a signpost to determine holidays based around easter (like Good Friday). You can read here in our SYNTAX guide for an example for Good Friday in the US.
Additionally, here is a link to an example for Good Friday for Georgian holidays. I think you can most likely do the same thing for the :ro definitions.
Let me know if you run into any issues producing the PR and feel free to request my review once it is open. Thank you!
from definitions.
ste26054
commented on September 25, 2024
PR done, but I have divergent test results with Travis: #131 (comment)
from definitions.
ppeble
commented on September 25, 2024
Closing this since the PR addressing it has been merged. This update will be included in the upcoming v5.0.0 definitions and v8.0.0 of the ruby gem. Thank you!
from definitions.
Related Issues (20)
- IT Holidays and sub-region HOT 7
- Berlin (de_be) International Women's day became a holiday HOT 1
- Some US holiday issues HOT 2
- Missing AE (United Arab Emirates) Holidays HOT 1
- Wrong indentation in de.yaml HOT 3
- Wrong lunar_to_solar result in vi.yaml
- "VI" is the ISO_3166-2 code for US Virgin Islands but this gem uses it for Vietnam
- Manage Belgium parent region
- Anzac Day in nsw_au
- data returned is inaccurate
- Can we have the mapping from region name and the code used
- Kenya HOT 3
- Add Juneteenth holiday to NYSE calendar
- Dynamic calculation for AU QLD Ekka holiday
- Add GitHub action to test PRs HOT 2
- `Internationaler Frauentag` missing for German MV HOT 2
- Missing in Germany HOT 1
- Store Bededag is no longer a dk holiday from 2024 HOT 1
- Adding US bank holiday
- Incorrect NZ regional holidays
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from definitions.