Comments (5)
Hello @ppeble, I'm a native Korean speaker.
First of all, Thank you for your active reaction. π
Here are my answers to the questions above.
-
Can you help us understand the difference in the holiday names as they stand today?
μΆμ
=Chuseok
(More appropriate translation) =Korean Thanksgiving Day
(Easy to understand in English)
But, Google translated fromμΆμ
intoThansgiving
. So, I suggested that It is more appropriate forThanksgiving
to be translated asChuseok
to Google Translator. -
Can you help us understand if our current definitions are correct?
μ€λ μ°ν΄ (The day before New Year's Day)
https://github.com/holidays/definitions/blob/master/kr.yaml#L77
I think30th day of Dec.
should be changed to the last day of last year.On the lunar calendar, 2015-12-29 is the last day of year.
On the lunar calendar, 2016-12-30 is the last day of year.
The last day of the year in lunar calendar shifting from year to year.And If it is now,
-
Now (Wrong)
μ€λ μ°ν΄ (The day before New Year's Day):lunar_to_solar(2017, 12, 30, :kr)
μ€λ (on the Day of New Year's Day):lunar_to_solar(2017, 1, 1, :kr)
μ€λ μ°ν΄ (The day after New Year's Day):lunar_to_solar(2017, 1, 2, :kr)
-
Correct
μ€λ μ°ν΄ (The day before New Year's Day):lunar_to_solar(2016, 12, 30, :kr)
μ€λ (on the Day of New Year's Day):lunar_to_solar(2017, 1, 1, :kr)
μ€λ μ°ν΄ (The day after New Year's Day):lunar_to_solar(2017, 1, 2, :kr)
I hope other native Korean speakers except me will make a confirmation.
-
-
Can you help us understand why we need to repeat 'Chuseok Holidays' on the 14th and 16th but not the 15th, as defined?
As the day before and the day after are also part of the holiday.
To be more specific,
14th day of August in lunar calendar: The day before Chuseok
15th day of August in lunar calendar: on the Day of Chuseok
16th day of August in lunar calendar: The day after Chuseokμ°ν΄
is a word collectively referring to these words(The day before Chuseok, The day after Chuseok).
And, I think that would be better to change descriptions more specific.Day Before After The day before New Year's Day μ€λ μ°ν΄ μ€λ μ λ The day after New Year's Day μ€λ μ°ν΄ μ€λ λ€μλ The day before Chuseok μΆμ μ°ν΄ μΆμ μ λ The day after Chuseok μΆμ μ°ν΄ μΆμ λ€μλ
I am always thankful for your efforts and contributions. π
from definitions.
@swcheon Thank you so much! I'm sorry that I didn't get back to this right away, just more baby stuff came up and I ran out of free time. π
I will take a look at this in the coming days and formulate a plan. Thank you again!
from definitions.
@ppeble I agree with your suggestions. μ λ
and λ€μλ
are more correct words. But I do not use that word in the real world. I think μΆμ μ°ν΄
is not so bad. How about using μΆμ μ°ν΄
as it is?
from definitions.
@EunJung-Seo I think that is also good.
from definitions.
if our current definitions are correct?
No, Current logic does not care Substitute holiday.
After 2013, μ€λ μ°ν΄ and μΆμ μ°ν΄ is applied Substitute holiday.
as described in κ΄κ³΅μμ 곡ν΄μΌμ κ΄ν κ·μ μΌλΆκ°μ λ Ήμ
:
If the holiday(or Sunday) falls on a New Year(μ€λ )'s Day or a Chuseok(μΆμ) holiday, the first business day following that day shall be a holiday. If the Children's Day(μ΄λ¦°μ΄λ ) falls on a Saturday or another holiday (Sunday, Buddha's birthday(μκ°νμ μΌ), etc.), the first business day following that day shall be a holiday.
After this rule, correction of this year's μ€λ holiday like this:
- 2017 27 Jan(Fri) - μ€λ μ°ν΄
- 2017 28 Jan(Sat) - μ€λ
- 2017 29 Jan(Sun) - not holiday
- 2017 30 Jan(Mon) - λ체 ν΄μΌ
ref here: https://ko.wikipedia.org/wiki/%EB%8C%80%EC%B2%B4%ED%9C%B4%EC%9D%BC%EC%A0%9C%EB%8F%84
from definitions.
Related Issues (20)
- Berlin (de_be) International Women's day became a holiday HOT 1
- Some US holiday issues HOT 2
- Missing AE (United Arab Emirates) Holidays HOT 1
- Wrong indentation in de.yaml HOT 3
- Wrong lunar_to_solar result in vi.yaml
- "VI" is the ISO_3166-2 code for US Virgin Islands but this gem uses it for Vietnam
- Manage Belgium parent region
- Anzac Day in nsw_au
- data returned is inaccurate
- Can we have the mapping from region name and the code used
- Kenya HOT 3
- Add Juneteenth holiday to NYSE calendar
- Dynamic calculation for AU QLD Ekka holiday
- Add GitHub action to test PRs HOT 2
- `Internationaler Frauentag` missing for German MV HOT 2
- Missing in Germany HOT 1
- Store Bededag is no longer a dk holiday from 2024 HOT 1
- Adding US bank holiday
- Incorrect NZ regional holidays
- Lundi de PentecΓ΄te - France
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from definitions.