Discuss JP holidays: The Emperor's Birthday change from 2019 about definitions HOT 6 CLOSED

I think that this is resolved now that I have merged holidays/holidays#315. Sorry for the delay! 🙇

from definitions.

Hello @anhnt2808 !!
Thank you for your report!!
I know that there is no Emperor's Birthday, holiday of 2019 in Japan. Because I'm Japanese.:)
In 2019, Japanese government considers adding new holidays May 1st instead of the Emperor's Birthday, but they have to change the holidays law.
I did not intend to change until the government announced, but it is a fact that there is no emperor's birthday in 2019, let's change 'jp.yml' first. :)
I will change it at this weekend. But other pull requests are waiting for merging, Would you wait for my next instruction?

from definitions.

Hi @ttwo32
Thank you for your answer.
Yes, I'm waiting. I think it will be fine until the end of 2018.
Should I close this issue, or just leave it here?
Thank you again for your support.
P/s: I'm working in Japan. That's why I face this problem. :)

from definitions.

@anhnt2808
Sorry, lazy response.

Should I close this issue, or just leave it here?

Just leave it.
After release, i will close this issue.:)

P/s: I'm working in Japan. That's why I face this problem. :)

Wow!! I'm glad to hear that. :)
I wonder that this gem is used in Japan.

from definitions.

@anhnt2808
I have pushed a commit.
This commit will be merged with other pull request holidays/holidays#308 .
But Owner's review is required. Could you wait until merged?

Hi @ppeble !!
Please review my Pull Request at your free time :)

from definitions.

@ttwo32
Sorry for the late reply.
Yes, I can wait.
Thank you for support.

from definitions.