add_parameter and nested Parameterized about param HOT 4 CLOSED

Hi @samimia-swks, I wouldn't be surprised to see bugs with add_parameter. Even if it's been available in the code base for a very long time, it's basically untested (I added a first simple test recently). However, running your code against the main branch I get this output which seems fine. I'd be nice to write a test that capture this behavior to avoid any potential regression.

a1.p_static = new_p_static
a2.p_static = default_p_static
a1.p_dynamic = new_p_dynamic
a2.p_dynamic = default_p_dynamic
b1.parameterized_static.p_static = new_p_static
b2.parameterized_static.p_static = default_p_static
b1.parameterized_dynamic.p_static = new_p_static
b2.parameterized_dynamic.p_static = default_p_static

from param.

Thanks for the quick response. I tried v2.0.0a3 and got the same (correct) result as you, but when trying this version with my main code base, encountered an unrelated bug which I just filed (#837). I am going to see if I can get around this seperate issue and confirm that my original issue is solved.

from param.

Note that Param 2 does have breaking changes; some previously accepted code will no longer be accepted in Param 2. But as the release notes will show, we think these changes are all improvements, and I hope you'll agree!

from param.

I think this issue can be closed since the related issue has its own solution, but feel free to reopen if that's not the case!

from param.