Giter VIP home page Giter VIP logo

Comments (21)

fingolfin avatar fingolfin commented on August 17, 2024 2

MatricesForHomalg passed in gap-system/PackageDistro#486 :-)

from homalg_project.

fingolfin avatar fingolfin commented on August 17, 2024 1

All good now. Thanks a lot for your efforts!

from homalg_project.

fingolfin avatar fingolfin commented on August 17, 2024

Several ways to fix this:

  • bundle those generated .xml files with the release tarball (no harm in that, I think?). With ReleaseTools that'd be done anyway
  • run makedoc.g as part of maketest.g to ensure these files are present
  • don't extract the tests each time maketest.g is run, instead extract them once and the bundle the extracted test files inside the release tarball (a bunch of packages do it that way, esp. those which use the extract_examples AutoDoc feature

from homalg_project.

fingolfin avatar fingolfin commented on August 17, 2024

Note that right now I manually blocked all Homalg packages from updating in https://github.com/gap-system/PackageDistro/pulls to prevent excessive re-running of the CI tests there (~250 jobs times 12 packages equals 3000 jobs which would be re-run each time the package distro is updated -- I'd rather not do that :-).

Hence if you have fixed this (be it by disabling the TestFile statements or by fixing the test files), make sure to notify me so that I can unblock them.

from homalg_project.

fingolfin avatar fingolfin commented on August 17, 2024

@mohamed-barakat if this is resolved with the next few hours by new releases of the affected packages, then those new versions can still make it into 4.12.0. Otherwise, I'll use whatever is in the distro right now (what that means can be checked by inspecting the various PRs, e.g. https://github.com/gap-system/PackageDistro/pull/493/files shows that Gauss is currently at 2022.03-01 in the distro)

from homalg_project.

mohamed-barakat avatar mohamed-barakat commented on August 17, 2024

I followed @zickgraf's suggestion in #488. Please check that the following packages pass your tests:

  • ToolsForHomalg
  • MatricesForHomalg
  • GradedRingForHomalg

If they do I can adapt the rest accordingly.

from homalg_project.

fingolfin avatar fingolfin commented on August 17, 2024

Tools and Graded already passed the test before. I'll look at matrices now

from homalg_project.

mohamed-barakat avatar mohamed-barakat commented on August 17, 2024

Tools and Graded already passed the test before. I'll look at matrices now

4ti2Interface should be also ready by now. I will do the rest in one go.

from homalg_project.

mohamed-barakat avatar mohamed-barakat commented on August 17, 2024

The rest will follow today.

from homalg_project.

mohamed-barakat avatar mohamed-barakat commented on August 17, 2024

All packages except LocalizeRingForHomalg & GradedModules are now released. The two remaining ones will be hopefully released within the next hour (see #500).

from homalg_project.

mohamed-barakat avatar mohamed-barakat commented on August 17, 2024

PR #500 will close this issue. If you still encounter failures it can be reopened.

from homalg_project.

fingolfin avatar fingolfin commented on August 17, 2024

PR #500 only deal with two packages. But also IO_ForHomalg, HomalgToCAS , LocalizeRingForHomalg, SCO, ExamplesForHomalg, RingsForHomalg are affected.

from homalg_project.

mohamed-barakat avatar mohamed-barakat commented on August 17, 2024

The others were dealt with in previous PRs. This was just the last one.

from homalg_project.

mohamed-barakat avatar mohamed-barakat commented on August 17, 2024

You probably mean that the mentioned packages still fail your tests?

from homalg_project.

fingolfin avatar fingolfin commented on August 17, 2024

I can't confirm this, at least not for IO_ForHomalg and HomalgToCAS which did not receive any further updates since their 2022.08-01 release. But I will recheck the others.

from homalg_project.

fingolfin avatar fingolfin commented on August 17, 2024

No, I did not re-run tests for these packages yet. But I will for those which received an updated today (which I just somehow missed). Which leaves IO_ForHomalg and HomalgToCAS

from homalg_project.

mohamed-barakat avatar mohamed-barakat commented on August 17, 2024

Oh, I forgot to bump the versions. I now bumped the versions of three updated but forgotten packages:

  • GradedRingForHomalg
  • HomalgToCAS
  • IO_ForHomalg

They will be released once the tests pass. Sorry for the delay.

from homalg_project.

fingolfin avatar fingolfin commented on August 17, 2024

The tests for RingsForHomalg unfortunately fail because they require Magma (and a lot more) to be installed. But I can't do that in GitHub CI, obviously. Ideally, the tests for Magma/Sage/... would only be run if the respective CAS is actually available?

from homalg_project.

fingolfin avatar fingolfin commented on August 17, 2024

Good news: all updates are merged now, with the exception of RingsForHomalg (but I see @zickgraf is working on that, thanks!)

from homalg_project.

zickgraf avatar zickgraf commented on August 17, 2024

RingsForHomalg 2022.08-03 and IO_ForHomalg 2022.08-03 are released, so RingsForHomalg should now also succeed :-)

from homalg_project.

mohamed-barakat avatar mohamed-barakat commented on August 17, 2024

Thank you for your patience and for the intensive testing.

from homalg_project.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.