Comments (2)
Reopening the issue - attached is the diff against 5168884 that demonstrates the problem (and makes the test case fail).
diff --git a/dz3-master/dz3-model/src/test/java/net/sf/dz3/device/actuator/impl/THTest.java b/dz3-master/dz3-model/src/test/java/net/sf/dz3/device/actuator/impl/THTest.java
index 504d99a..16fba38 100644
--- a/dz3-master/dz3-model/src/test/java/net/sf/dz3/device/actuator/impl/THTest.java
+++ b/dz3-master/dz3-model/src/test/java/net/sf/dz3/device/actuator/impl/THTest.java
@@ -126,7 +126,7 @@ public class THTest {
Damper damperWestBathroom = new SwitchDamper("damper_westbathroom", switchWestBathroom, 0.8, 1.0, 10);
Damper damperWest = new SwitchDamper("damper_west", switchWestDamper, 0.8, 1.0, 10);
- Damper damperWestBoosterFan = new SwitchDamper("damper_westboosterfan", switchWestBoosterFan, 0.8, 1.0, 10, true);
+ Damper damperWestBoosterFan = new SwitchDamper("damper_westboosterfan", switchWestBoosterFan, 0.8, 0.0, 10, true);
Set<Damper> west = new LinkedHashSet<>();
@@ -185,7 +185,7 @@ public class THTest {
assertEquals(WRONG_STATE, true, switchKitchen.getState());
assertEquals(WRONG_STATE, true, switchWestBathroom.getState());
assertEquals(WRONG_STATE, true, switchWestDamper.getState());
- assertEquals(WRONG_STATE, false, switchWestBoosterFan.getState());
+ assertEquals(WRONG_STATE, true, switchWestBoosterFan.getState());
// The above stateChanged() also changed the state of the Unit to "running",
// next stateChanged() will be handled differently
@@ -234,7 +234,7 @@ public class THTest {
assertEquals(WRONG_STATE, true, switchKitchen.getState());
assertEquals(WRONG_STATE, true, switchWestBathroom.getState());
assertEquals(WRONG_STATE, true, switchWestDamper.getState());
- assertEquals(WRONG_STATE, false, switchWestBoosterFan.getState());
+ assertEquals(WRONG_STATE, true, switchWestBoosterFan.getState());
logger.info("Damper map: {}", Arrays.asList(dc.getDamperMap()));
from dz.
Revision 8020ef6 fixes this particular problem. However, changes for #48 are interfering with this behavior. Fixing #131 will take care of this, so closing this issue.
from dz.
Related Issues (20)
- Implement generic Zigbee2MQTT (Z2M hereinafter) reader and writer HOT 1
- Implement Z2M sensor support
- Implement Z2M switch support
- Implement stacking switch
- Call for heating blocks 1-wire network on reactive branch HOT 1
- Pipeline overrun with slow actuators HOT 2
- Allow a calendar event to override a zone hold
- Reactive branch lost the period name both on Swing Console and HCC Remote HOT 1
- Docker image: figure out how to pass rxtxSerial into the image with Jib plugin
- Docker image: figure out how to support Google OAuth2 flow from inside the container
- Implement sensor set for SONOFF SNZB-02 Zigbee Temperature and Humidity Sensor HOT 2
- Reduce PidEconomizer jitter on reaching the target temperature HOT 1
- ConcurrentModificationException on paintChart()
- SonarCloud GitHub Action is broken
- Economizer turns on when it shouldn't when AC is on and target is reached HOT 1
- ConcurrentModificationException in MQTT listeners when getFlux() is called at fast pace HOT 1
- Eliminate multiple MQTT connections to the same broker
- Implement imperative sensor set for SONOFF SNZB-02 Zigbee Temperature and Humidity Sensor
- Allow Thermostat and Zone to exist without having a setpoint
- Implement system wide status dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dz.