Cache path for Homebrew Bundler RubyGems set up by setup-homebrew not valid about actions HOT 9 CLOSED

Can you link to an example that's failing? It seems to be working as expected in https://github.com/Homebrew/brew/actions/runs/3573828538/jobs/6008467172#step:3:11

from actions.

Sure thing - can you see the contents of the steps here:

https://github.com/PatTheMav/homebrew-custom/actions/runs/3574049627/jobs/6008840464#step:20:3

from actions.

Yeah this is a problem introduced with actions/cache v2 (v1 works and is what we still use in some places).

The problem is v2 strongly assumes GITHUB_WORKSPACE and the working directory are identical. While I don't particularly agree with that assumption since it clearly breaks things when that's not the case, we also probably shouldn't be replacing GITHUB_WORKSPACE like we do in setup-homebrew.

I'd like to get rid of our GITHUB_WORKSPACE symlink and follow the self-hosted path we currently have. There are some compatibility concerns in doing so however, but may have to bite the bullet at some point.

from actions.

So for now the fix is to use the v1 action until you found the bandwidth to update the action? Sounds fair enough, will try to check back every now and then for a new version (or maybe brew spits it out in a changelog).

from actions.

Yeah we kind of backed ourselves into a corner by recommending Homebrew/actions/setup-homebrew@master instead of using a v1 branch.

I think a lot will be ok except a handful of workflows that reference GITHUB_WORKSPACE directly. Just need to coordinate that a bit across repos.

from actions.

@Bo98 I guess whatever we do will need to be backwards and forwards compatible 🙃

from actions.

Somewhat impossible situation given either the symlink exists or it doesn't. The only real middle ground would be to reverse it so that the clone lies in GITHUB_WORKSPACE and the symlink is in the Taps directory instead.

Still a small compatibility concern for the workflows where we hack a workaround for cache v2 with rm $GITHUB_WORKSPACE, though we'd want to drop that workaround anyway.

from actions.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

from actions.

This should now be fixed.

from actions.