homebridge-people not working about docker-homebridge HOT 3 CLOSED

Hi @glassbase,

There are two issues here. The first is the user which Homebridge runs as did not have permission to run ping. I'll fix this problem in an update to this image.

Test file (this is pretty much what makes homebridge-people works):

const ping = require('ping')

ping.sys.probe('192.168.1.68', (state) => {
  console.log(state)
})

Test results, running the latest version of ping as the Homebridge user:

# install latest ping library
npm install ping@latest

# test before fixing permissions
/homebridge $ s6-setuidgid abc node test.js
false

# test after fixing permissions
/homebridge $ chmod 4755 /bin/ping
/homebridge $ s6-setuidgid abc node test.js
true # <-- Success

The second problem is that this only works on a newer version of the ping library than homebridge-people ships with. The plugin ships with version 0.1.10 while the latest version is 0.2.2. If I do the same tests using version 0.1.10 they always fail.

Test results, running the version 0.1.10 of ping as the Homebridge user:

# install ping version 0.1.10
npm install [email protected]

# test before fixing permissions
/homebridge $ s6-setuidgid abc node test.js
false

# test after fixing permissions
/homebridge $ chmod 4755 /bin/ping
/homebridge $ s6-setuidgid abc node test.js
false

This second issue can only be fixed by the plugin author updating the dependencies in their package.json:

https://github.com/PeteLawrence/homebridge-people/blob/f27609d4a14722ed74fb376b92c7b11e603ae3c3/package.json#L19

from docker-homebridge.

Well thanks for investigating. Going to get presence to work in HA and push that into HB.

from docker-homebridge.

Permissions for /bin/ping have been fixed in the latest build.

from docker-homebridge.