Comments (2)
So let me get this straight-
inspect_app is happy if it has the app already on the system, where it's going to definitely need a bundle ID, and thus, inspect_app can 100% of the time get the ID.
I hear you about SparkleUpdateInfoProvider
, although I would think that the ID in the actual app should be considered canonical, even over anything provided as Input variables or overrides.
I think it's very safe to assume that an app, if downloaded, will have a bundle ID, so yes, you can build a package recipe, knowing that it's going to need something to get the bundle ID (and version).
What that something is, is tricky. I think AppDmgVersioner right before PkgCreator is a good candidate, as it should be able to handle ANYTHING that is going to be immediately preceding PkgCreator. Right?
from recipe-robot.
Yes, if we've run inspect_app()
then we should be pretty confident that we have the correct bundle id (and yes, that bundle id should override anything stored before it; I'll make that change).
If we haven't successfully inspected an app at some point along the line, it's likely that RR isn't going to be able to produce a full recipe set without manual intervention. But "likely" ≠ "guaranteed."
I'll try to find some edge case examples.
from recipe-robot.
Related Issues (20)
- 2.0.0rc1: Script output in app is not realtime, out of order HOT 3
- Fails on checking for recipes HOT 6
- FR: Include PlistReader with Apps as part of .pkg recipes
- 2.0rc2: Sparkle URLs collect sparkle:version key value in output instead of sparkle:shortVersionString HOT 1
- Building off #173, out Team ID for Code Signature output
- Sparkle Feed Causes Python Explosion HOT 2
- Sparkle Feed Causes dev Branch Recipe Creation Failure
- Recipe Robot 2.0: Incorrect "Minimum System version" Requirement? HOT 1
- Sparkle Feed Explosion for non-Sparkle feed HOT 5
- Mac with Recipe Robot but no autopkg produces pinwheels with no output HOT 1
- Mac with configured default RecipeCreateLocation that doesn't exist causes failure HOT 2
- Support for JamfUploader recipes HOT 2
- Recipe Robot incorrectly suggests AppPkgCreator for a pkg inside a dmg
- Support for DMG inside a ZIP HOT 1
- PKG rather than DMG as an option for Munki recipe's HOT 1
- Switch option to specify description when you get "[WARNING] No GitHub description provided." while running Recipe Robot HOT 5
- [ERROR] Sorry, I can't determine which version key to use for this app. HOT 8
- Don't skip pkg recipe if download recipe downloads a pkg HOT 1
- Parsing BBEdit Sparkle feed causes error HOT 3
- Switch from nose to pytest based tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from recipe-robot.