Giter VIP home page Giter VIP logo

Comments (2)

sheagcraig avatar sheagcraig commented on July 28, 2024

So let me get this straight-
inspect_app is happy if it has the app already on the system, where it's going to definitely need a bundle ID, and thus, inspect_app can 100% of the time get the ID.

I hear you about SparkleUpdateInfoProvider, although I would think that the ID in the actual app should be considered canonical, even over anything provided as Input variables or overrides.

I think it's very safe to assume that an app, if downloaded, will have a bundle ID, so yes, you can build a package recipe, knowing that it's going to need something to get the bundle ID (and version).

What that something is, is tricky. I think AppDmgVersioner right before PkgCreator is a good candidate, as it should be able to handle ANYTHING that is going to be immediately preceding PkgCreator. Right?

from recipe-robot.

homebysix avatar homebysix commented on July 28, 2024

Yes, if we've run inspect_app() then we should be pretty confident that we have the correct bundle id (and yes, that bundle id should override anything stored before it; I'll make that change).

If we haven't successfully inspected an app at some point along the line, it's likely that RR isn't going to be able to produce a full recipe set without manual intervention. But "likely" ≠ "guaranteed."

I'll try to find some edge case examples.

from recipe-robot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.