Comments (15)
@ceciliamvrie adding some additional regressions found after going through all components.
- Checkboxes: Custom Checkbox border is different locally
- Chips: Clickable chip does not have raised state after being clicked
- Chips: Chip with avatar does not have raised state after being clicked
- Chips: Custom remove icon chip does not have raised state after being clicked
- Icons: Shadow not appearing on icon buttons after being clicked
- Icons: Primary color is different between local and smc website (#03A9F4 on website and #3F51B4 locally)
- Snackbar: Shadow not appearing on snackbar buttons after being clicked
from styled-material-components.
Checklist:
This is just a copy/paste of the issues above, so that we can keep track of progress on these.
- Tooltips: Covering the entire page on click or hover
- Menus: Not rendering / throwing errors when not passed anchorEl as a prop
- Buttons: Displaying style regressions (ex: elevation)
-
Dropdown: Disappearing on selecting menu item(maybe not a huge priority because we have a draft MD2 one) -
TextField: Row specification isn't working, results in multiline text area[see comment below on why this is not a bug] - Checkboxes: Custom Checkbox border is different locally
- Chips: Clickable chip does not have raised state after being clicked
- Chips: Chip with avatar does not have raised state after being clicked
- Chips: Custom remove icon chip does not have raised state after being clicked
- Icons: Shadow not appearing on icon buttons after being clicked
- Icons: Primary color is different between local and smc website (#03A9F4 on website and #3F51B4 locally) [may be fixed in https://github.com//pull/318]
- Snackbar: Shadow not appearing on snackbar buttons after being clicked
from styled-material-components.
Also it looks like these are the issues fixed in this PR #314 - @ceciliamvrie feel free to update anything that's inaccurate
- Enable custom-styled checkboxes
- Clicking outside BottomSheet modal should close it
- Clicking outside temporary drawer should close it
from styled-material-components.
Gonna work on the button shadow
from styled-material-components.
I've checked on my current pr, and I'm not seeing the issue where the custom checkbox border is different locally than from the site. I'm gonna check that box off
from styled-material-components.
I'll do menus not rendering / throwing erros when not passed anchorEl as prop
from styled-material-components.
Gonna work on the chips
from styled-material-components.
PR #316 in for the menu fix. It was really only an issue in the implementation changes in the pages file, and not really anything with the component itself.
I think when adding flow/eslint it suggested setting state with a function instead of an object ... but the event being passed to that function was not being passed in properly.
from styled-material-components.
I'm starting work on the dropdown text field issue.
from styled-material-components.
Nevermind on the above ... I think priority for that issue is low because Merlin has a TextFieldDropdown component built out already.
I will now look into the tooltip stuff.
from styled-material-components.
#314 updated the Portal a bit, so you may want to wait until it lands to work on the tooltip (or just copy in the updates) @dekkofilms
from styled-material-components.
Hmm, how close is that to being merged? @martahj
from styled-material-components.
@dekkofilms Hopefully soon, @gregorelee is taking a look now
from styled-material-components.
I'm not sure the textfield multiline issue is a genuine bug. In this PR app, you can see that the text area with two rows lets the user keep typing indefinitely, but does not expand vertically as they do so like the multiline text field. I don't see anything in the current material spec about multiline text fields, but honestly the experience seems pretty good. Thoughts? @danieltisdale @nataliaisabelle
from styled-material-components.
Going to look into why colors differ between local and website builds
from styled-material-components.
Related Issues (20)
- iOS 11 Text field cursor jumping issue in all modals
- Update box shadow of Card component
- styles for rows or individual cells HOT 2
- TypeScript support HOT 1
- Add list of currently supported / not supported material components to the readme HOT 1
- Cannot read 'property' of undefined HOT 1
- Eliminate Background Scrolling on Fullscreen dialog Component HOT 2
- [TextField] Accept onkeyDown prop
- TabIndex in Menu
- Dialog component misspelled
- Bottomsheet animation is not currently working as intended and style updates
- [RFC] Screen Size Context Refactor Proposal HOT 4
- On mobile devices where width is 320px or less, the side nav drawer is taking up the whole screen
- Allow onClick handler for Card component
- Fix switches onHover state
- Button ripples not rendering correctly HOT 1
- Menu renders an incorrect location
- Allow Dialog to close on outside click
- Button Menu: Edge (17): menu not opening to available space
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from styled-material-components.