Honeybadger gives a shit about exceptions about honeybadger-ruby HOT 4 CLOSED

Good point. It's going to be a little more complicated than just rescue Exception though, since we don't want to rescue things like SignalException. I'm assigning this to our chief gemologist.

from honeybadger-ruby.

I'm not sure I have a problem rescuing SignalException. That rescue statement is only rescuing exceptions raised from the #send_to_honeybadger method, which is what delivers the notice payload to our servers. When the exception is rescued, the result is a log message, and no exception re-raised. Thoughts?

from honeybadger-ruby.

Couldn't a signal be raised while that method is running? And if you're only concerned with exceptions raised from your own method, it seems to me you should be able to restrict the set to rescue, not broaden it. I'm -1 on this.

from honeybadger-ruby.

Yeah, I take back my original statement... In this case, rescuing StandardError is the desired behavior (and rescuing Exception is a really bad idea). We could limit it further, but I don't think it makes much difference here. The goal is to make sure that application errors encountered during notification don't get raised. If anyone has a specific example of it causing problems, I'm happy to re-evaluate my position.

from honeybadger-ruby.