Giter VIP home page Giter VIP logo

Comments (8)

hongquan avatar hongquan commented on August 16, 2024 3

I already move screenshots to Git repo.

from cobang.

hongquan avatar hongquan commented on August 16, 2024

Maybe your build environment blocks Internet access? It said

url is a zero length file [https://i.imgur.com/K3TU9bm.png]

But that URL is actually valid, you can check it yourself.

from cobang.

xiota avatar xiota commented on August 16, 2024

Internet access was okay because build server downloads fresh sources prior to building. Seems like was probably a temporary Imgur issue because successfully builds now. But why are those files on Imgur instead of in the git repo and source tarball? Imgur can go down or refuse connections for maintenance, captcha checks, or other reasons.

from cobang.

hongquan avatar hongquan commented on August 16, 2024

Because before your report, there was no issue with Imgur accessibility, and I don't want to store binary files in Git repo.

from cobang.

xiota avatar xiota commented on August 16, 2024

I think binaries are fine / common for screenshots, icons, and some other types of files. If you decide not to add them to the repo, I'll ask the aur maintainer to add them to the package.

from cobang.

hongquan avatar hongquan commented on August 16, 2024

I will move the screenshots to Git repo.

from cobang.

hongquan avatar hongquan commented on August 16, 2024

I planned to move the screenshots to Git repo, but then I don't know how to specify the image location in the appdata file. Its specs says that:

The value of the <image/> tag is a direct URL to a screenshot uploaded to a public location on the web.

So it seems that we still have to use https://... URL here, and using https://github.com is not different than using Imgur service.

from cobang.

xiota avatar xiota commented on August 16, 2024

I will move the screenshots to Git repo.

Would be appreciated.

I don't know how to specify the image location

Something like: https://raw.githubusercontent.com/hongquan/CoBang/main/LICENSE.txt

Even if the link is not changed, I think it would be beneficial to have a backup of the images in the git repo.

Is there a way to verify the appdata file without downloading the links?

using https://github.com is not different than using Imgur service.

Using a single site / service is less prone to failure than using more. To even access the source in the first place, Github has to be working. So it's less likely to fail during build than Imgur. Also, from personal use, Github uptime is much better than Imgur, which frequently goes down for "maintenance".

from cobang.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.