JsonSchemaException is not right. about python-fastjsonschema HOT 5 CLOSED

you should have for the exception class

  def __init__(self, *args, **kwargs):
    super().__init__(*args, **kwargs)

with no need for the message member variable. Then doing

raise JsonSchemaException(message)

will ensure that the str() of the exception is the message, which is the behavior of the base Exception class. Your way requires special treatment and will not get printed correctly by the default handler, for instance.

test case:

raise fastjsonschema.JsonSchemaException("test")

will print

JsonSchemaException:

instead of

JsonSchemaException: test

from python-fastjsonschema.

Hi. Thanks for the report but I don't understand what you are talking about. Can you maybe provide better explanation or test which shows the bug?

from python-fastjsonschema.

Agreed. This is something I experienced when using the library, too.

from python-fastjsonschema.

Fixed in master, will release with the next version where I will improve little bit JSON's formats.

from python-fastjsonschema.

If you want to keep the message compatibility I would suggest to go with something like the following

class JsonSchemaException(ValueError):
    """
    Exception raised by validation function. Contains ``message`` with
    information what is wrong.
    """

    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)

    @property
    def message(self):
      return str(self)

It's somewhat more efficient and achieves the same result :-)

from python-fastjsonschema.