'example.de' (and many others hostnames) not valid with hostname format about python-fastjsonschema HOT 6 CLOSED

This is the current regex:

^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]{1,62}[A-Za-z0-9])$

As far as I see it, this means, the last part can never be exactly 2 chars long. This is a huge problem, as there are many tlds with 2 chars. (.de, .fr, etc.)

In the PR I'll probably use a different regex. But: As I said in the other issue today: I don't think regexes are a good solution for formats that can easily be validated using python standard library means (other than re).

from python-fastjsonschema.

I agree, some formats would be better to validate by some extra library than by regexps. Also, some regexps are are not super correct for some cases. But it brings dependencies which I want to avoid until it's not really necessary. :-)

But maybe, if license allows it, I could copy-paste some code into this library to keep an eye on performance and avoid problems with changing dependencies. Will put on my todo list to check possibilities.

from python-fastjsonschema.

I agree, some formats would be better to validate by some extra library than by regexps. Also, some regexps are are not super correct for some cases. But it brings dependencies which I want to avoid until it's not really necessary. :-)

In some cases, like ipv4 and ipv6, you could use functionality like the ipaddress module that doesn't require additional dependencies.
But for some other formats you might need other dependencies and I understand that you'd like to avoid them. You could start with the formats that are covered by the standard python library.

from python-fastjsonschema.

@horejsek Thanks for merging! I would be very happy if you can do a bugfix release with this in the near future, because this issue keeps us from rolling out a component that we switched from jsonschema to your library (because of draft7 support, performance and I like it better :) )

from python-fastjsonschema.

Done, v2.3 :-)

from python-fastjsonschema.

Glad it helped your component! :-)

from python-fastjsonschema.