Given a schema like <div class="highlight highlight-source-yaml notranslate positi

This was with draft7 <div class="highlight highlight-source-python notranslate pos

bad code gen for integer with exclusiveMinimum/exclusiveMaximum about python-fastjsonschema HOT 6 CLOSED

horejsek commented on July 1, 2024

bad code gen for integer with exclusiveMinimum/exclusiveMaximum

from python-fastjsonschema.

Comments (6)

kapilt commented on July 1, 2024 1

oh.. i see what you mean, thanks

from python-fastjsonschema.

horejsek commented on July 1, 2024

exclusiveMaximum and exclusiveMinimum can be booleans in Draft 04. Since Draft 06 it should be numeric. See the release notes: https://json-schema.org/draft-06/json-schema-release-notes.html

By default, Draft 07 is used. If you want to use Draft 04, specify that in your schema. Example:

{
    "$schema": "http://json-schema.org/draft-04/schema",
    "type": "object",
    "properties": {
        "period": {
            "exclusiveMaximum": true,
            "exclusiveMinimum": true,
            "maximum": 1209600,
            "minimum": 60,
            "type": "integer"
        }
    }
}

from python-fastjsonschema.

kapilt commented on July 1, 2024

This was with draft7

>>> fastjsonschema._get_code_generator_class(schema)
<class 'fastjsonschema.draft07.CodeGeneratorDraft07'>

from python-fastjsonschema.

manugarri commented on July 1, 2024

Actually I see the schema validation failling because of exclusiveMaximum for draft 0.7

Given the schema:

downloaded_schema = {'$id': '/properties/products/items/properties/downloaded_on',
 'type': 'integer',
 'title': 'The Downloaded_on Schema ',
 'default': 0,
 'minimum': 0,
 'maximum': 2147483647,
 'exclusiveMaximum': False,
 'examples': [1521336798]}

Any valid number (timestamp) fails when doing this:

# valid timestamp
downloaded_on = 1567155851
validate = fastjsonschema.compile(downloaded_schema)
validate(downloaded_on)

The error being:

<ipython-input-113-d2b2a5d40dc9> in <module>
      1 validate = fastjsonschema.compile(downloaded_schema)
----> 2 validate(downloaded_on)

<string> in validate__properties_products_items_properties_downloaded_on(data)

JsonSchemaException: data must be smaller than False

Removing the exclusiveMaximum clause fixes the issue

from python-fastjsonschema.

horejsek commented on July 1, 2024

Since draft 0.6 exclusiveMaximum have to be number, not boolean. If you want to use it the old way, you need to state your schema is draft 0.4 as I showed before.

from python-fastjsonschema.

manugarri commented on July 1, 2024

Oh, that makes a lot of sense!, thanks a ton!.

from python-fastjsonschema.

Recommend Projects