Comments (6)
blestab
commented on May 28, 2024
1
- Keep using
shortid, migrate tonanoidafter we upgrade thereact-scripts.
Sounds like a plan
from hospitalrun-frontend.
SamuelQZQ
commented on May 28, 2024
@tehKapa I'd like to be assigned to this task.
from hospitalrun-frontend.
matteovivona
commented on May 28, 2024
@SamuelQZQ okay. let's be very careful if Nano ID works the same way as Short ID
from hospitalrun-frontend.
SamuelQZQ
commented on May 28, 2024
@tehKapa The shortid uses a dynamic length id. But the nanoid use a fixed-length id. So, after migrate to nanoid, the question is, what length should we use? I think 9 or 10 is enough. Here is a collision calculator: Nano ID Collision Calculator
from hospitalrun-frontend.
SamuelQZQ
commented on May 28, 2024
@tehKapa
Finally, I found that the nanoid above 3.0 met a bug in Create React App, which only fixed after Create React App 4.0.
See: nanoid doc about Create React App.
We have two choices:
- Use the nanoid 2.0 first, and upgrade it to the latest version after we upgrade the
react-scripts. - Keep using
shortid, migrate tonanoidafter we upgrade thereact-scripts.
Personally prefer the latter.
from hospitalrun-frontend.
matteovivona
commented on May 28, 2024
damn these updates are getting more and more complicated. @HospitalRun/core-contributors what do you think?
from hospitalrun-frontend.
Related Issues (20)
- Imaging Request - requestedBy should store the currently logged in user id HOT 7
- Duplicate Patient Modal cannot be triggered HOT 10
- ReportIncident save button always rendered HOT 8
- Lab - In the Request Lab routine make the visit field required HOT 5
- New Imaging Request - required visit not enforced HOT 7
- New Lab Request - required visit not enforced HOT 2
- Focus of menu item "Visits" disappears when I view the details HOT 2
- ViewAppointments Tests Have a Console Error HOT 4
- Test patients/care-goals/CareGoalTab.test.tsx on MacOS runner fails HOT 4
- Lack of Visible Focus - WCAG Success Criterion 2.4.7
- NewLabRequest.test.tsx is flaky HOT 4
- Creating new patient - validation of the phone number is wrong HOT 1
- Creating new patient - validation messages not appropriate HOT 5
- Cancel Button HOT 5
- Update Portuguese translation HOT 8
- Type 'unknown' is not assignable to type '(prevState: ImagingRequestError | undefined) => ImagingRequestError | undefined'.
- Live demo is not working.
- Imrpove UI in sidebar HOT 11
- Error occur in while install and run Hospital Run Frontend HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hospitalrun-frontend.