Giter VIP home page Giter VIP logo

Comments (19)

flanger001 avatar flanger001 commented on September 13, 2024 11

I will be happy to fork this into a new organization and give people maintainer access on it.

from two_factor_authentication.

anasteele206 avatar anasteele206 commented on September 13, 2024 7

I would be open to taking ownership of this repo to oversee further development.

from two_factor_authentication.

baarkerlounger avatar baarkerlounger commented on September 13, 2024 4

Have forked this here https://github.com/baarkerlounger/two_factor_authentication for the time being (happy to create PRs from that here or have commits cherry-picked if that helps, if this repo gets going again). Works in testing so far with Rails 7 and Turbo, and specs run again.

from two_factor_authentication.

jherdman avatar jherdman commented on September 13, 2024 2

@Houdini sorry to pile on in this PR, but it'd be helpful to know the state of this library.

from two_factor_authentication.

kengreeff avatar kengreeff commented on September 13, 2024 2

@Houdini do you think we could add a few more people to this as maintainers?

from two_factor_authentication.

steobrien avatar steobrien commented on September 13, 2024 1

@Houdini a quick ping on this – thanks for your work maintaining this library so far. Before submitting a PR to fix a bug I've found, I want to make sure the project is active and accepting contributions?

from two_factor_authentication.

strzibny avatar strzibny commented on September 13, 2024 1

Thanks @flanger001!

Btw I just released devise-otp 0.3.0 which I use with Rails 7 and Hotwire.

from two_factor_authentication.

flanger001 avatar flanger001 commented on September 13, 2024

I think the best option here is going to be forking unfortunately.

from two_factor_authentication.

sudhindra avatar sudhindra commented on September 13, 2024

@flanger001 Can you please let me know if any forked library supports rails 6.1, happy to contribute
@Houdini

from two_factor_authentication.

jasonperrone avatar jasonperrone commented on September 13, 2024

@sudhindra I opened a PR a while ago for the Rails 6 stuff. You could fork your own project and steal the PRs you need.

from two_factor_authentication.

jasonperrone avatar jasonperrone commented on September 13, 2024

Sorry, it wasn't me who did that PR. Losing track because I am finding I have to fix a lot of gems lately for either Rails 6.1 compatibility or Ruby 3 compatibility #204

from two_factor_authentication.

strzibny avatar strzibny commented on September 13, 2024

@baarkerlounger thanks a lot!

from two_factor_authentication.

baarkerlounger avatar baarkerlounger commented on September 13, 2024

Seems like no movement in this repo still. Given that, would anyone else like to help maintain a fork ☝️? What do people think about publishing to RubyGems? (Would need a new name presumably).

from two_factor_authentication.

strzibny avatar strzibny commented on September 13, 2024

I actually decided to fix https://github.com/wmlele/devise-otp. It now works for Rails 7 and the only thing missing is updating README and doing a proper release. So if someone needs maintained and up to date OTP solution join us :). I got commit and RubyGems push rights from the original dev, so no blockers.

from two_factor_authentication.

baarkerlounger avatar baarkerlounger commented on September 13, 2024

@strzibny any major advantages to that project over this one?

from two_factor_authentication.

strzibny avatar strzibny commented on September 13, 2024

Not really, although I am not sure if two_factor_authentication ships with JavaScript QR code library to show the image. I like it since it's simple, small codebase, and we used it at work (I maintained Rails 5 fork before going to fix it for Rails 7).

from two_factor_authentication.

flanger001 avatar flanger001 commented on September 13, 2024

Thanks @strzibny (love Deployment From Scratch btw) and @baarkerlounger for taking care of this stuff - I actually did end up forking it into a new org myself: https://github.com/devise2fa/two_factor_authentication - but I never did anything with it afterwards because I felt the whole thing of cutting a gem was going to be a pain. However, if anyone wants to get in and actually do it, I'll happily turn over the org.

from two_factor_authentication.

baarkerlounger avatar baarkerlounger commented on September 13, 2024

@flanger001 I submitted a pull request to your repo with all the changes I made on my fork. Any interest in merging and releasing as a new gem still? (Happy to be added as a maintainer also), or are you moving on to devise-otp rather?

from two_factor_authentication.

flanger001 avatar flanger001 commented on September 13, 2024

@baarkerlounger I'm very sorry! I just got this and I will respond to you there!

from two_factor_authentication.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.