Add C code generation for value lists about dbcc HOT 1 CLOSED

Thanks for opening this issue, ideally they'd all be like this one, well documented and reasoned out.

I seem to recall the reason it was removed is that the grammar was causing problems with some DBC files for reasons I cannot remember and will have to remind myself of, and seeing as the program was not using the enum values, the offending bit in the grammar was removed. Development in this project is mainly driven by "why does this not work with my DBC file?".

To answer your questions:

I would probably handle duplicate enum values with your second option, by prefixing the enum with the enum name. It does generate long names, but I think it is sensible to do by default. A command line option could be given to surpress that behaviour, but I would only add that if someone actually asked for it.

You could use the grammar to detect valid C identifiers, the "ident" type encodes most of the rules that detemines whether an id is valid (as both a C id and a DBC one). By adding the suffix "_e" to the generated enumeration values as well then you could avoid having to detect whether or not an enum if a keyword as well.

Looking at the commit you've made, there's still more to do, but it's a good start, and it does not seem to break anything. It might be worth developing a branch "feature/enum" before merging into master. I'd like to add bounds checking and printing before merging.

from dbcc.